Duplicate verification error message fix.#112
Merged
Conversation
…already verified.
There was a problem hiding this comment.
Pull Request Overview
Adds handling for cases where a verification request has already been processed, logging an error and returning an error response.
- Introduces a type check for
models.VerificationResponseto detect duplicate verifications - Logs an error and returns a 500-style JSON response with message "request already verified"
Comments suppressed due to low confidence (2)
internal/api/server.go:101
- Using a 500 Internal Server Error for an already verified request may mislead clients; consider returning a 409 Conflict or 400 Bad Request with an appropriate response type to reflect a client-side issue.
return Callback500JSONResponse{
internal/api/server.go:96
- There is no existing test coverage for the duplicate verification path; add a unit or integration test to ensure this branch behaves as expected.
// Check if request is already verified
martinsaporiti
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added correct error message for a case when verification request was already verified.