Skip to content

Commit cd4ed3f

Browse files
authored
Deprecation warning for FDL (firebase#12999)
1 parent 90721b3 commit cd4ed3f

File tree

6 files changed

+11
-5
lines changed

6 files changed

+11
-5
lines changed

.github/workflows/dynamiclinks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- name: Xcode
3838
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
3939
- name: FirebaseDynamicLinks
40-
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseDynamicLinks.podspec
40+
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseDynamicLinks.podspec --allow-warnings
4141

4242
spm:
4343
# Don't run on private repo unless it is a PR.
@@ -80,7 +80,7 @@ jobs:
8080
- name: Setup Bundler
8181
run: scripts/setup_bundler.sh
8282
- name: PodLibLint Storage Cron
83-
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseDynamicLinks.podspec --platforms=ios ${{ matrix.flags }}
83+
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseDynamicLinks.podspec --platforms=ios ${{ matrix.flags }} --allow-warnings
8484

8585
quickstart:
8686
# Don't run on private repo unless it is a PR.

FirebaseDynamicLinks/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Unreleased
2+
- [added] Added deprecation warning in advance of August 25, 2025 Dynamic Links service shutdown. (#12995)
3+
14
# 10.3.0
25
- [fixed] Fixes issue where `utmParametersDictionary` / `minimumAppVersion` were not provided and their value were set to `[NSNull null]` instead of `nil`.
36

FirebaseDynamicLinks/Sources/Public/FirebaseDynamicLinks/FIRDynamicLinks.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ NS_ASSUME_NONNULL_BEGIN
3131
* @abstract A class that checks for pending Dynamic Links and parses URLs.
3232
* This class is available on iOS only.
3333
*/
34-
34+
DEPRECATED_MSG_ATTRIBUTE(
35+
"Firebase Dynamic Links is deprecated and the service will shut down on August 25, 2025.")
3536
NS_EXTENSION_UNAVAILABLE_IOS("Firebase Dynamic Links is not supported for iOS extensions.")
3637
API_UNAVAILABLE(macos, tvos, watchos)
3738
NS_SWIFT_NAME(DynamicLinks)

ReleaseTooling/Sources/FirebaseManifest/FirebaseManifest.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public let shared = Manifest(
4444
Pod("FirebaseAuth", zip: true),
4545
Pod("FirebaseCrashlytics", zip: true),
4646
Pod("FirebaseDatabase", platforms: ["ios", "macos", "tvos"], zip: true),
47-
Pod("FirebaseDynamicLinks", platforms: ["ios"], zip: true),
47+
Pod("FirebaseDynamicLinks", allowWarnings: true, platforms: ["ios"], zip: true),
4848
Pod("FirebaseFirestoreInternal", allowWarnings: true, platforms: ["ios", "macos", "tvos"]),
4949
Pod("FirebaseFirestore", allowWarnings: true, platforms: ["ios", "macos", "tvos"], zip: true),
5050
Pod("FirebaseFunctions", zip: true),

scripts/create_spec_repo/Sources/SpecRepoBuilder/main.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ struct SpecRepoBuilder: ParsableCommand {
270270
func pushPodspec(forPod pod: URL, sdkRepo: String, sources: [String],
271271
flags: [String], shell: Shell = Shell.shared) throws -> Int32 {
272272
let sourcesArg = sources.joined(separator: ",")
273-
let flagsArgArr = allowWarnings ?flags + ["--allow-warnings"] : flags
273+
let flagsArgArr = allowWarnings ? flags + ["--allow-warnings"] : flags
274274
let flagsArg = flagsArgArr.joined(separator: " ")
275275

276276
do {

scripts/health_metrics/pod_test_code_coverage_report.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ if [ $SDK == "FirebasePerformance" ]; then
6060
elif [ $SDK == "FirebaseFirestore" ]; then
6161
scripts/install_prereqs.sh Firestore ${PLATFORM} xcodebuild
6262
scripts/third_party/travis/retry.sh scripts/build.sh Firestore ${PLATFORM} xcodebuild
63+
elif [ $SDK == "FirebaseDynamicLinks" ]; then
64+
scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb "${SDK}".podspec --verbose --allow-warnings --platforms="$(tr '[:upper:]' '[:lower:]'<<<${PLATFORM})" --test-specs="${TEST_SPEC}"
6365
else
6466
# Run unit tests of pods and put xcresult bundles into OUTPUT_PATH, which
6567
# should be a targeted dir of actions/upload-artifact in workflows.

0 commit comments

Comments
 (0)