Skip to content

Conversation

24-105
Copy link
Owner

@24-105 24-105 commented Dec 21, 2024

Description

The execution environment name is now obtained when executing the cdk command.

This pull request includes several changes to the cdk project, focusing on code cleanup, type definition, and configuration updates. The most important changes include removing the CdkStack class, defining a new TargetEnv type, and updating the tsconfig.json file for better code consistency.

Code Cleanup:

  • cdk/lib/cdk-stack.ts: Removed the CdkStack class and its associated imports and example resource code.

Type Definition:

  • cdk/lib/util/targetEnv.ts: Added a new TargetEnv type and a targetEnv function to handle environment variable NODE_ENV and map it to the TargetEnv type.

Configuration Updates:

  • cdk/tsconfig.json: Consolidated array formatting in the compilerOptions section for lib and typeRoots properties. [1] [2]

Related issues


Check List

  • (No compilation errors)
  • (No Nest.js startup errors)
  • (No errors in tests)

@24-105 24-105 self-assigned this Dec 21, 2024
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 88.37% 456/516
🟡 Branches 66.07% 37/56
🟢 Functions 91.86% 79/86
🟢 Lines 87.34% 407/466

Test suite run success

97 tests passing in 29 suites.

Report generated by 🧪jest coverage report action from 4264bdc

@24-105 24-105 merged commit ef0d500 into develop Dec 21, 2024
4 checks passed
@24-105 24-105 deleted the feature/aws-cdk-bin branch December 21, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant