Routes and User-Home #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElvisHernandez
requested changes
Jun 8, 2024
There was a problem hiding this comment.
Left some comments about things to change before merging @Adnel1
| @@ -200,13 +201,13 @@ def create_category(user_id): | |||
|
|
|||
| #Get all of user's categories | |||
| @api.route('/users/<int:user_id>/categories', methods=['GET']) | |||
| @jwt_required() # Requires a valid JWT token | |||
| # @jwt_required() # Requires a valid JWT token | |||
There was a problem hiding this comment.
This should be an authenticated endpoint, i.e. @jwt_required should be set on this function
| @@ -184,11 +184,12 @@ def search(): | |||
| return jsonify({"error": "Error fetching data from API."}), 500 | |||
|
|
|||
| # Create category for user | |||
| @api.route('/users/<int:user_id>/categories', methods=['POST']) | |||
| @api.route('/users/<int:user_id>/category', methods=['POST']) | |||
There was a problem hiding this comment.
This endpoint should be authenticated, i.e. should have @jwt_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Able to create categories needs to connect front to backend