String errors#452
Closed
moldhouse wants to merge 2 commits into
Closed
Conversation
…ormat the error format of different providers sometimes diverges from OpenAI. the string-error feature does not try to parse errors into the OpenAI format, but leaves it up to the user. when enabled, the is a wrapper around the original error message. This also enables cases where the error message is not even valid json
Owner
|
Thanks again for this - this is now supported for any custom error types via https://docs.rs/async-openai/latest/async_openai/error/enum.OpenAIError.html#variant.Boxed Hence closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #448
In the issue, the idea of exposing a
serde_json::Valuewas discussed. In some internal server error cases, evenOpenAIdoes return error messages that are not json. This made me wonder if representing the error asStringmight give users more flexibility. Would be eager to get some feedback if this matches what you had in mind @64bitI'm uncertain if the second commit (offering a helper method to parse the raw string into a type) provides value / goes beyond the scope of this library, happy to remove it.