Skip to content

Conversation

Nikschavan
Copy link

Fixes #145

@7rulnik
Copy link
Owner

7rulnik commented Jul 15, 2021

@Nikschavan hi! I'm looking into changes and it's not clear to me what did you change.

@Nikschavan
Copy link
Author

Nikschavan commented Jul 15, 2021

I actually ran npm run lint and fixed it's changes as well (I saw that was being run into travis) If lint changes are excluded this is how the diff would look like -

-const postcssFlexibility = () => ({
+module.exports = () => {
+	return {
 	postcssPlugin: 'postcss-flexibility',
 	Once(root) {
 		root.walkRules(rule => {
@@ -15,8 +16,7 @@ const postcssFlexibility = () => ({
 			}
 		});
 	}
-});
-
-postcssFlexibility.postcss = true;
+	}
+};
 
-export default postcssFlexibility;
+module.exports.postcss = true;

Here's the diff file - https://share.bsf.io/rRujRGoW

let me know if this is still unclear, I can re-do the PR with separate commits for the fix and the lint fix

@7rulnik
Copy link
Owner

7rulnik commented Jul 15, 2021

@Nikschavan oh I see. I had some worries about export default. To be honest, I would like to use it, but seems that there are some problems with transpiling. Will take a look!

@Nikschavan
Copy link
Author

Did you check this @7rulnik

@adamyala
Copy link

Many thank yous @Nikschavan 🙏
Your change fixed the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error "[object Object] is not a PostCSS plugin" when using with Laravel Mix

3 participants