From 2a0cebc18f3065845fc5c1e09b488c3d41751b3b Mon Sep 17 00:00:00 2001 From: Arthur Aulicino Date: Mon, 4 Jul 2022 03:18:35 -0300 Subject: [PATCH 1/3] ci: include package assemblies in code coverage --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 2303de0..5cbe31a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -94,7 +94,7 @@ jobs: githubToken: ${{ secrets.GITHUB_TOKEN }} testMode: editmode unityVersion: ${{ needs.get-unity-version.outputs.unity-version }} - coverageOptions: "generateAdditionalMetrics;generateHtmlReport;generateHtmlReportHistory;generateBadgeReport;assemblyFilters:+;pathFilters:+**/PackageCache/${{ needs.build.outputs.package-name }}*/**" + coverageOptions: "generateAdditionalMetrics;generateHtmlReport;generateHtmlReportHistory;generateBadgeReport;assemblyFilters:+;pathFilters:+**/Packages/${{ needs.build.outputs.package-name }}*/**" - uses: actions/upload-artifact@v3 if: always() with: From 3f335d8b376e874ea5bc3ee2d30448f79484ef20 Mon Sep 17 00:00:00 2001 From: Arthur Aulicino Date: Mon, 4 Jul 2022 03:32:20 -0300 Subject: [PATCH 2/3] ci: tweak pathFilter and remove spaces from substitution variable --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5cbe31a..140fad0 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -94,7 +94,7 @@ jobs: githubToken: ${{ secrets.GITHUB_TOKEN }} testMode: editmode unityVersion: ${{ needs.get-unity-version.outputs.unity-version }} - coverageOptions: "generateAdditionalMetrics;generateHtmlReport;generateHtmlReportHistory;generateBadgeReport;assemblyFilters:+;pathFilters:+**/Packages/${{ needs.build.outputs.package-name }}*/**" + coverageOptions: "generateAdditionalMetrics;generateHtmlReport;generateHtmlReportHistory;generateBadgeReport;assemblyFilters:+;pathFilters:+**/${{needs.build.outputs.package-name}}*/**" - uses: actions/upload-artifact@v3 if: always() with: From 9eb7a4e31e54e88cc95d5589a67f8c6686b5793d Mon Sep 17 00:00:00 2001 From: Arthur Aulicino Date: Mon, 4 Jul 2022 03:46:25 -0300 Subject: [PATCH 3/3] ci: explicitly specify assemblies in assemblyfilter --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 140fad0..8010c52 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -94,7 +94,7 @@ jobs: githubToken: ${{ secrets.GITHUB_TOKEN }} testMode: editmode unityVersion: ${{ needs.get-unity-version.outputs.unity-version }} - coverageOptions: "generateAdditionalMetrics;generateHtmlReport;generateHtmlReportHistory;generateBadgeReport;assemblyFilters:+;pathFilters:+**/${{needs.build.outputs.package-name}}*/**" + coverageOptions: "generateAdditionalMetrics;generateHtmlReport;generateHtmlReportHistory;generateBadgeReport;assemblyFilters:+UnityCoroutineSubstitute.*" - uses: actions/upload-artifact@v3 if: always() with: