Skip to content

Conversation

heidinett
Copy link
Collaborator

Fixes Issue #7 - W21C logo replaced with that of ACCESS Atmosphere WG.

@heidinett heidinett requested a review from KAUR1984 August 27, 2024 23:40
@navidcy
Copy link
Contributor

navidcy commented Aug 27, 2024

@angus-g why we don't see the docs previews here? Is it because we transferred the repo?

@navidcy navidcy added the documentation 📕 Improvements or additions to documentation label Aug 27, 2024
@angus-g
Copy link
Collaborator

angus-g commented Aug 27, 2024

@angus-g why we don't see the docs previews here? Is it because we transferred the repo?

I see the preview, unless you're referring to something else?
image

@navidcy
Copy link
Contributor

navidcy commented Aug 27, 2024

@angus-g why we don't see the docs previews here? Is it because we transferred the repo?

I see the preview, unless you're referring to something else? image

I changed the repo settings in the readthedocs and it worked!

Copy link
Contributor

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's converge on the name and then ensure that we change it everywhere (e.g. in the docs also).

@heidinett
Copy link
Collaborator Author

@navidcy - do we now have consensus on the name "atmosphere cookbook"?
Would be great to merge this PR before the ACCESS workshop next week.

@navidcy navidcy changed the title Fix Issue #7: Changed logo to that of ACCESS Atmosphere WG Rename repo + replace logo with ACCESS Atmosphere WG logo Aug 29, 2024
@heidinett
Copy link
Collaborator Author

great. Thanks @navidcy!

@navidcy
Copy link
Contributor

navidcy commented Aug 29, 2024

There are a bunch of "atmospheric" at https://atmospheric-cookbook--9.org.readthedocs.build/en/9/

@heidinett
Copy link
Collaborator Author

Would you prefer that I open a new issue to replace "atmospheric" with "atmosphere" in Readthedocs, or address it in this issue?

@navidcy
Copy link
Contributor

navidcy commented Aug 29, 2024

Let's address it here? Whatever suits you.

@navidcy navidcy self-requested a review August 29, 2024 04:30
Copy link
Contributor

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

feel free to merge @heidinett when you deal with "atmospheric" -> "atmosphere"

@heidinett
Copy link
Collaborator Author

@navidcy, I have replaced references to "atmospheric" with "atmosphere" and created a COPYRIGHT.txt file.

@heidinett heidinett merged commit df3993c into main Aug 29, 2024
3 checks passed
@navidcy navidcy deleted the heidi/fix-readmelogo-issue-7 branch August 29, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📕 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants