Extract CommitParams to individual commitments

[t-bast]

We introduce a new channel codec version where:

• we extract per-commitment parameters (commitment format and params such as dust_limit which we may want to dynamically update in the future)
• we clean-up the splice iterations on the Commitments structure
• we remove the funding transaction from the confirmed local funding status (once confirmed, we don't need it anymore: it is wasting DB space for no good reason, we can get it from the blockchain)
• we add a maxClosingFeerate_opt to the closing state, to allow limiting the feerate used in RBF attempts for safe transactions

[t-bast]

@sstone this PR is now ready for the taproot work to be rebased on top of it to validate the v5 codecs!

[t-bast]

Rebased to include the bitcoin-lib update.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.11934% with 21 lines in your changes missing coverage. Please review.

Project coverage is 86.16%. Comparing base (f14b92d) to head (3ac5b01).
Report is 29 commits behind head on master.

Files with missing lines	Patch %	Lines
...ire/internal/channel/version4/ChannelCodecs4.scala	87.87%	8 Missing ⚠️
...wire/internal/channel/version4/ChannelTypes4.scala	92.10%	6 Missing ⚠️
...cala/fr/acinq/eclair/SpendFromChannelAddress.scala	0.00%	1 Missing ⚠️
...in/scala/fr/acinq/eclair/channel/Commitments.scala	98.88%	1 Missing ⚠️
...inq/eclair/channel/fund/InteractiveTxBuilder.scala	96.00%	1 Missing ⚠️
...la/fr/acinq/eclair/transactions/Transactions.scala	94.44%	1 Missing ⚠️
...ire/internal/channel/version0/ChannelCodecs0.scala	75.00%	1 Missing ⚠️
...ire/internal/channel/version3/ChannelCodecs3.scala	80.00%	1 Missing ⚠️
...wire/internal/channel/version3/ChannelTypes3.scala	95.45%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3118      +/-   ##
==========================================
+ Coverage   85.80%   86.16%   +0.35%     
==========================================
  Files         236      239       +3     
  Lines       21299    22031     +732     
  Branches      859      822      -37     
==========================================
+ Hits        18275    18982     +707     
- Misses       3024     3049      +25     

Files with missing lines	Coverage Δ
...in/scala/fr/acinq/eclair/channel/ChannelData.scala	100.00% <100.00%> (ø)
...c/main/scala/fr/acinq/eclair/channel/Helpers.scala	93.24% <100.00%> (+2.08%)	⬆️
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala	83.76% <100.00%> (+0.66%)	⬆️
...inq/eclair/channel/fsm/ChannelOpenDualFunded.scala	86.38% <100.00%> (-0.10%)	⬇️
...q/eclair/channel/fsm/ChannelOpenSingleFunded.scala	92.77% <100.00%> (-0.62%)	⬇️
...inq/eclair/channel/fsm/CommonFundingHandlers.scala	92.30% <100.00%> (ø)
...la/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala	82.72% <100.00%> (+2.36%)	⬆️
...cinq/eclair/crypto/keymanager/CommitmentKeys.scala	100.00% <100.00%> (ø)
...la/fr/acinq/eclair/io/OpenChannelInterceptor.scala	90.24% <100.00%> (-0.54%)	⬇️
...n/scala/fr/acinq/eclair/json/JsonSerializers.scala	96.00% <ø> (ø)
... and 16 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pm47]

LGTM (I feel like I have already reviewed this?)

I suggest adding some temporary code in Setup.scala that prevents app startup. It would give us time to rebase feature branches and maybe refine codecs, without worrying about backward compat for users that run master.

[t-bast]

I suggest adding some temporary code in Setup.scala that prevents app startup. It would give us time to rebase feature branches and maybe refine codecs, without worrying about backward compat for users that run master.

Good idea, done in a8bed6f and tested locally. I did this in Boot.scala so that integration tests are not affected, and provided an override to allow starting the node anyway for our testnet tests.