Split commit nonces from funding nonce in tx_complete
#3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit nonces and funding nonce provided in `tx_complete` are actually completely orthogonal: - the commit nonces must be provided whenever the *next* commitment format is using taproot - the funding nonce must be provided whenever the *previous* commitment format is using taproot It thus makes more sense to split them into separate TLVs.
t-bast
force-pushed
the
split-tx-complete-tlvs
branch
from
ac48c48 to
f847125
Compare
sstone
reviewed
Aug 25, 2025
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/InteractiveTxTlv.scala
Outdated
Show resolved
Hide resolved
sstone
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit nonces and funding nonce provided in
tx_completeare actually completely orthogonal:It thus makes more sense to split them into separate TLVs, as proposed here.