This repository was archived by the owner on Oct 25, 2023. It is now read-only.
feat: use custom namespace rather than stack-name#178
Open
abdul-ashour wants to merge 1 commit intoACloudGuru:masterfrom
Open
feat: use custom namespace rather than stack-name#178abdul-ashour wants to merge 1 commit intoACloudGuru:masterfrom
abdul-ashour wants to merge 1 commit intoACloudGuru:masterfrom
Conversation
|
As the author of #142 I'm curious what we can do to move this PR along. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
Allow using custom namespace value rather than the stack-name for alerts configured with patterns.
Closes #142
How did you implement it:
The implementation simply considers
namespacevalue specified in the alert. The changes do not introduce any additional optionHow can we verify it:
You just need to add
namespaceto your alert definition then deploy to AWS. You should see your metric created under the specified namespace.