Skip to content

Conversation

eanzhao
Copy link
Contributor

@eanzhao eanzhao commented Aug 8, 2024

For issue #3602

Copy link

vizipi bot commented Aug 8, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
57.14% chopin.fan 6 16
21.43% jason-hoopox 39 6
17.86% ZhangXin 35 5
10.71% louis.li 6 3
10.71% 轩辕焮痕 1 3
7.14% fengyan2023 10 2

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 20.91%[src/AElf.Kernel.FeatureManager/FeatureManagerAElfModule.cs]
  • 51.61%[...test/AElf.Kernel.FeatureDisable.Tests/FeatureDisableTestM]
  • 51.61%[...src/AElf.Kernel.FeatureDisable.Core/FeatureDisableConstan]
  • 51.61%[...test/AElf.Kernel.FeatureDisable.Tests/OptionalLogEventPro]
  • 20.91%[test/AElf.Kernel.FeatureManager.Tests/IMockService.cs]
  • 0.00%[...src/AElf.Kernel.FeatureManager/FeatureDisableConfiguratio]
  • 63.70%[...test/AElf.Kernel.FeatureDisable.Tests/AElf.Kernel.Feature]
  • 0.00%[...src/AElf.Kernel.FeatureManager.Core/IFeatureDisableServic]
  • 51.61%[...test/AElf.Kernel.FeatureDisable.Tests/KernelFeatureManage]
  • 0.00%[...test/AElf.Kernel.FeatureManager.Tests/FeatureDisableServi]
  • @eanzhao eanzhao changed the title Move feature disable service related code to feature manager module Refactor feature management module Aug 8, 2024
    Copy link

    codecov bot commented Aug 8, 2024

    Codecov Report

    ❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
    ✅ Project coverage is 90.62%. Comparing base (4881469) to head (3570b8e).
    ⚠️ Report is 150 commits behind head on dev.

    Files with missing lines Patch % Lines
    ...eatureManagement.Core/IFeatureManagementService.cs 50.00% 3 Missing ⚠️
    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3603      +/-   ##
    ==========================================
    - Coverage   90.64%   90.62%   -0.03%     
    ==========================================
      Files         676      674       -2     
      Lines       26068    26065       -3     
      Branches     2346     2346              
    ==========================================
    - Hits        23629    23621       -8     
    - Misses       2324     2329       +5     
      Partials      115      115              
    Files with missing lines Coverage Δ
    ...Management.Core/FeatureManagementCoreAElfModule.cs 100.00% <ø> (ø)
    ...Management/FeatureDisableConfigurationProcessor.cs 100.00% <100.00%> (ø)
    ...rnel.FeatureManagement/FeatureManagementService.cs 100.00% <100.00%> (ø)
    ....FeatureManagement/IDisabledFeatureListProvider.cs 100.00% <ø> (ø)
    ...ct/Application/PlainTransactionExecutingService.cs 93.54% <100.00%> (ø)
    ...lf.Kernel.SmartContract/SmartContractAElfModule.cs 100.00% <ø> (ø)
    src/AElf.Kernel/KernelAElfModule.cs 100.00% <ø> (ø)
    ...eatureManagement.Core/IFeatureManagementService.cs 50.00% <50.00%> (ø)

    ... and 1 file with indirect coverage changes

    🚀 New features to boost your workflow:
    • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant