Create main.yml #22
Merged
Create main.yml #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadikneipp
approved these changes
Oct 22, 2024
sadikneipp
reviewed
Oct 22, 2024
.github/workflows/main.yml
Outdated
|
|
||
| # Run tests | ||
| - name: Run core tests | ||
| run: python -m unittest |
There was a problem hiding this comment.
We can try to use https://github.com/google/googletest
There was a problem hiding this comment.
Using absl.testing.absltest. googletest is the C++ testing framework.
lukebaumann
force-pushed
the
lukebaumann-patch-2
branch
3 times, most recently
from
d06d6ce to
9b09904
Compare
Based on [etils GitHub Action](https://github.com/google/etils/blob/main/.github/workflows/pytest_and_autopublish.yml). References tests that are not currently in the repository.
lukebaumann
force-pushed
the
lukebaumann-patch-2
branch
from
9b09904 to
59b4b1a
Compare
sadikneipp
reviewed
Oct 22, 2024
|
|
||
| # Run tests | ||
| - name: Run core tests | ||
| run: python -m unittest discover --pattern "*_test.py" --start-directory "pathwaysutils/test" |
There was a problem hiding this comment.
Does this call into absl test? Asking since it's using unittest.
There was a problem hiding this comment.
abseil doesn't have special logic for test discovery. Since absl.testing.absltest is built on top of unittest, if you just use absl.testing.absltest.TestCase over unittest.TestCase in your code, python -m unittest would also work.
Apparently fails if we are making use of some absl flags which we are not doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on etils GitHub Action.
References tests that are not currently in the repository.