feat: Add docker-compose and make based recipes #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds off of the existing inference/vLLM recepies and introduces an alternate workflow for running the TPU recipes using
docker-composeandmake.The goal of this change is to improve the user experience by making the recipes easier to use without needing to copy/paste the docker commands. It also allows for the variables that a use might want to set to be configured in a .env file so they can manage their state.
These can be put alongside the existing recepies and won't impact their functionality.
The key changes are:
make setup,make up, andmake benchmark.I believe this new workflow will make the recipes more accessible and easier to use, especially for those who are new to the platform. I'm happy to receive any feedback or suggestions for improvement.