From 7f1075e1679ac7a3a538929fb876bd992c1cb6fb Mon Sep 17 00:00:00 2001 From: Feidias Ioannidis Date: Mon, 20 Oct 2025 15:06:41 +0000 Subject: [PATCH 1/2] Only skip Kueue installation if cluster has newer version --- src/xpk/core/kueue_manager.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xpk/core/kueue_manager.py b/src/xpk/core/kueue_manager.py index 31810a3a8..7858221c5 100644 --- a/src/xpk/core/kueue_manager.py +++ b/src/xpk/core/kueue_manager.py @@ -86,9 +86,9 @@ def install_or_upgrade( return_code, installed_version = self.__get_installed_kueue_version() if return_code == 0: - if installed_version and installed_version >= self.kueue_version: + if installed_version and installed_version > self.kueue_version: xpk_print( - f"Kueue version {installed_version} is already up to date. Skipping" + f"Cluster has a newer Kueue version, {installed_version}. Skipping" " installation." ) return 0 From 8fb811ba79cf4be7ebe92f06f0b51ea05bfb21bb Mon Sep 17 00:00:00 2001 From: Feidias Ioannidis Date: Mon, 20 Oct 2025 15:07:57 +0000 Subject: [PATCH 2/2] test fix --- src/xpk/core/kueue_manager_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xpk/core/kueue_manager_test.py b/src/xpk/core/kueue_manager_test.py index 672a7e820..f69c22b05 100644 --- a/src/xpk/core/kueue_manager_test.py +++ b/src/xpk/core/kueue_manager_test.py @@ -80,11 +80,11 @@ def test_version_check_when_kueue_not_installed(self, mock_run_for_value): ) @patch("xpk.core.kueue_manager.KueueManager._KueueManager__install") @patch("xpk.core.kueue_manager.KueueManager._KueueManager__configure") - def test_install_or_upgrade_when_up_to_date( + def test_install_or_upgrade_when_newer_version_already_installed( self, mock_configure, mock_install, mock_get_version ): """Test install_or_upgrade when Kueue is already up to date.""" - mock_get_version.return_value = (0, "v0.12.2") + mock_get_version.return_value = (0, "v0.12.3") kueue_config = MagicMock(spec=KueueConfig) result = self.kueue_manager.install_or_upgrade(kueue_config)