Skip to content

Install kueue resources if version is the same or lower #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2025
Merged

Install kueue resources if version is the same or lower #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f1075e
Only skip Kueue installation if cluster has newer version
FIoannides Oct 20, 2025
8fb811b
test fix
FIoannides Oct 20, 2025
5b6d05c
Merge branch 'develop' into install-kueue-resources
FIoannides Oct 20, 2025
2dc04dc
Merge branch 'develop' into install-kueue-resources
FIoannides Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/xpk/core/kueue_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ def install_or_upgrade(
return_code, installed_version = self.__get_installed_kueue_version()

if return_code == 0:
if installed_version and installed_version >= self.kueue_version:
if installed_version and installed_version > self.kueue_version:
xpk_print(
f"Kueue version {installed_version} is already up to date. Skipping"
f"Cluster has a newer Kueue version, {installed_version}. Skipping"
" installation."
)
return 0
Expand Down
4 changes: 2 additions & 2 deletions src/xpk/core/kueue_manager_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ def test_version_check_when_kueue_not_installed(self, mock_run_for_value):
)
@patch("xpk.core.kueue_manager.KueueManager._KueueManager__install")
@patch("xpk.core.kueue_manager.KueueManager._KueueManager__configure")
def test_install_or_upgrade_when_up_to_date(
def test_install_or_upgrade_when_newer_version_already_installed(
self, mock_configure, mock_install, mock_get_version
):
"""Test install_or_upgrade when Kueue is already up to date."""
mock_get_version.return_value = (0, "v0.12.2")
mock_get_version.return_value = (0, "v0.12.3")
kueue_config = MagicMock(spec=KueueConfig)

result = self.kueue_manager.install_or_upgrade(kueue_config)
Expand Down
Loading