Conversation
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to 5e2a592
- Looked at
296lines of code in2files - Took 1 minute and 19 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_Zv66JEmFQhuhtLEi
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.
⌛ 21 hours left in your free trial, upgrade for $20/seat/month or contact us.
| parser_weaviate.add_argument("--url", type=str, help="URL of Weaviate instance") | ||
| parser_weaviate.add_argument("--api_key", type=str, help="Weaviate API key") | ||
| parser_weaviate.add_argument("--openai_api_key", type=str, help="Openai API key") | ||
| parser_weaviate.add_arguments( |
There was a problem hiding this comment.
The method add_arguments is incorrect and will cause a runtime error as it does not exist in argparse. It should be add_argument.
| parser_weaviate.add_arguments( | |
| parser_weaviate.add_argument( |
| weaviate_import.upsert_data() | ||
| return weaviate_import | ||
|
|
||
| def __init__(self, args): |
There was a problem hiding this comment.
The connection_type argument is used here but it is not defined in the argument parser for the import script. This will cause an error when trying to access self.args["connection_type"].
To fix this, add the connection_type argument to the parser in the make_parser method:
| def __init__(self, args): | |
| parser_weaviate.add_argument( | |
| "--connection-type", type=str, choices=["local", "cloud"], default="cloud", | |
| help="Type of connection to Weaviate (local or cloud)" | |
| ) |
for more information, see https://pre-commit.ci
|
Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month. If you have any questions, reach us at help@ellipsis.dev |
|
@emekaokoli19 did you test the newest version of the code with a weaviate instance? |
@dhruv-anand-aintech I am sorry for the late reply, I was out for a few days but I am back now. Yes the code was tested with a weaviate instance and it works |
|
@emekaokoli19 you need to make sure that it works for any import command. Here it asks me for index name, which it should be using the name from the VDF_META.json file (see other DBs' implementation). It also fails because openai_api_key is not set. This is not a required API key for importing datasets. You need to make sure the code works without it being set (using Let's have a pair programming session to finish off this task. Please message me on discord to set a time |
for more information, see https://pre-commit.ci


/claim #74
@dhruv-anand-aintech Please take a look
Summary:
Enhances Weaviate export and import functionalities with support for multiple connection types, batch processing, and integration of OpenAI API key, with import functionality needing completion.
Key points:
ExportWeaviateandImportWeaviate.ExportWeaviate.ImportWeaviate, but actual data upsert code is commented out.Generated with ❤️ by ellipsis.dev