Skip to content

enthalpy_pred_types that predict T seem to be missing T on edge? #444

@zingale

Description

@zingale

If you look at the code in MaestroEnthalpyAdvance.cpp, we do:

  // needs to be done after the state was returned to the full state.
  if ((enthalpy_pred_type == predict_T_then_rhohprime) ||
       (enthalpy_pred_type == predict_T_then_h) ||
       (enthalpy_pred_type == predict_Tprime_then_h)) {
       `(sedge, rho0_edge_old, rhoh0_edge_old, rho0_edge_new,
                     rhoh0_edge_new);
  }

but in HfromRhoTedge, it is not clear where we are getting the temperature from.

In the original MAESTRO, we passed in the temperature.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions