ArenaProfiler: Fix clang-tidy warning (#4128)

WeiqunZhang · web-flow · commit 8627fbe22d52 · 2024-09-04T17:00:06.000Z
When TINY_PROFILING is off, ~ArenaProfiler is trivial. So clang-tidy
wants us to use `= default`.
diff --git a/Src/Base/AMReX_Arena.cpp b/Src/Base/AMReX_Arena.cpp
@@ -660,14 +660,21 @@ The_Comms_Arena ()
     }
 }
 
-Arena::ArenaProfiler::~ArenaProfiler () {
 #ifdef AMREX_TINY_PROFILING
+
+Arena::ArenaProfiler::~ArenaProfiler ()
+{
     if (m_do_profiling) {
         TinyProfiler::DeregisterArena(m_profiling_stats);
     }
-#endif
 }
 
+#else
+
+Arena::ArenaProfiler::~ArenaProfiler () = default;
+
+#endif
+
 void Arena::ArenaProfiler::profile_alloc ([[maybe_unused]] void* ptr,
                                           [[maybe_unused]] std::size_t nbytes) {
 #ifdef AMREX_TINY_PROFILING

Original file line number	Diff line number	Diff line change
`@@ -660,14 +660,21 @@ The_Comms_Arena ()`
`660`	`660`	`}`
`661`	`661`	`}`
`662`	`662`
`663`		`-Arena::ArenaProfiler::~ArenaProfiler () {`
`664`	`663`	`#ifdef AMREX_TINY_PROFILING`
	`664`	`+`
	`665`	`+Arena::ArenaProfiler::~ArenaProfiler ()`
	`666`	`+{`
`665`	`667`	`if (m_do_profiling) {`
`666`	`668`	`TinyProfiler::DeregisterArena(m_profiling_stats);`
`667`	`669`	`}`
`668`		`-#endif`
`669`	`670`	`}`
`670`	`671`
	`672`	`+#else`
	`673`	`+`
	`674`	`+Arena::ArenaProfiler::~ArenaProfiler () = default;`
	`675`	`+`
	`676`	`+#endif`
	`677`	`+`
`671`	`678`	`void Arena::ArenaProfiler::profile_alloc ([[maybe_unused]] void* ptr,`
`672`	`679`	`[[maybe_unused]] std::size_t nbytes) {`
`673`	`680`	`#ifdef AMREX_TINY_PROFILING`