Add explanatory comment to ParticleReduce #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

atmyers merged 1 commit into AMReX-Codes:development from atmyers:particle_reduce_comment

Aug 20, 2025

Member

atmyers commented Aug 20, 2025

Explain why we don't use ParIter in the ParticleReduce methods.

The proposed changes:

fix a bug or incorrect behavior in AMReX
add new capabilities to AMReX
changes answers in the test suite to more than roundoff level
are likely to significantly affect the results of downstream AMReX users
include documentation in the code and/or rst files, if appropriate


          Add explanatory comment to ParticleReduce

478a404

atmyers requested review from WeiqunZhang and ax3l

August 20, 2025 18:37

WeiqunZhang approved these changes

View reviewed changes

atmyers merged commit 7886010 into AMReX-Codes:development

75 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet