Skip to content

Add explanatory comment to ParticleReduce #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

Add explanatory comment to ParticleReduce #4620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Src/Particle/AMReX_ParticleReduce.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,8 @@ ReduceSum (PC const& pc, int lev_min, int lev_max, F const& f)
grid_tile_ids.push_back(kv.first);
ptile_ptrs.push_back(&(kv.second));
}

// We avoid ParIter here to allow reductions after grids change but prior to calling Redistribute()
#ifdef AMREX_USE_OMP
#pragma omp parallel for if (!system::regtest_reduction) reduction(+:sm)
#endif
Expand Down Expand Up @@ -418,6 +420,8 @@ ReduceMax (PC const& pc, int lev_min, int lev_max, F const& f)
grid_tile_ids.push_back(kv.first);
ptile_ptrs.push_back(&(kv.second));
}

// We avoid ParIter here to allow reductions after grids change but prior to calling Redistribute()
#ifdef AMREX_USE_OMP
#pragma omp parallel for if (!system::regtest_reduction) reduction(max:r)
#endif
Expand Down Expand Up @@ -619,6 +623,8 @@ ReduceMin (PC const& pc, int lev_min, int lev_max, F const& f)
grid_tile_ids.push_back(kv.first);
ptile_ptrs.push_back(&(kv.second));
}

// We avoid ParIter here to allow reductions after grids change but prior to calling Redistribute()
#ifdef AMREX_USE_OMP
#pragma omp parallel for if (!system::regtest_reduction) reduction(min:r)
#endif
Expand Down Expand Up @@ -815,6 +821,8 @@ ReduceLogicalAnd (PC const& pc, int lev_min, int lev_max, F const& f)
grid_tile_ids.push_back(kv.first);
ptile_ptrs.push_back(&(kv.second));
}

// We avoid ParIter here to allow reductions after grids change but prior to calling Redistribute()
#ifdef AMREX_USE_OMP
#pragma omp parallel for if (!system::regtest_reduction) reduction(&&:r)
#endif
Expand Down Expand Up @@ -1012,6 +1020,8 @@ ReduceLogicalOr (PC const& pc, int lev_min, int lev_max, F const& f)
grid_tile_ids.push_back(kv.first);
ptile_ptrs.push_back(&(kv.second));
}

// We avoid ParIter here to allow reductions after grids change but prior to calling Redistribute()
#ifdef AMREX_USE_OMP
#pragma omp parallel for if (!system::regtest_reduction) reduction(||:r)
#endif
Expand Down Expand Up @@ -1247,6 +1257,8 @@ ParticleReduce (PC const& pc, int lev_min, int lev_max, F const& f, ReduceOps& r
grid_tile_ids.push_back(kv.first);
ptile_ptrs.push_back(&(kv.second));
}

// We avoid ParIter here to allow reductions after grids change but prior to calling Redistribute()
#if !defined(AMREX_USE_GPU) && defined(AMREX_USE_OMP)
#pragma omp parallel for
#endif
Expand Down
Loading