Skip to content

Delay some synchronize calls in addParticles #4623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

Delay some synchronize calls in addParticles #4623

merged 1 commit into from
Aug 20, 2025

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Aug 20, 2025

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from WeiqunZhang August 20, 2025 22:34
@atmyers atmyers enabled auto-merge (squash) August 20, 2025 22:44
@atmyers atmyers merged commit fb0b093 into AMReX-Codes:development Aug 20, 2025
75 checks passed
WeiqunZhang added a commit to WeiqunZhang/amrex that referenced this pull request Aug 29, 2025
@WeiqunZhang
Fix a bug in AMReX-Codes#4623
d5fc1fb 
The issue is MakeIter(lev) enables tiling whereas MakeIter(lev, MFItInfo{})
does not.
@ax3l ax3l mentioned this pull request Aug 29, 2025
Merged
WeiqunZhang added a commit that referenced this pull request Aug 29, 2025
@WeiqunZhang
Fix a bug in #4623 (#4631)
5d1b6c2 
The issue is MakeIter(lev) enables tiling whereas MakeIter(lev,
MFItInfo{}) does not.

Fix for a bug introduced in #4623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atmyers @WeiqunZhang