Use p.id().is_valid()
consistently
#4635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies further cleaning to particles.
The largest change is the replacement of all numeric id comparisons with
id().is_valid()
andid().make_invlid()
. Previously,id() > 0
,id() < 0
,id() < 1
andid() <= 0
withid() = - id()
were used, making the treatment of id == 0 inconsistent (particle ids start at 1 because of this).Both
ptd.m_aos[i]
andmake_particle<ConstParticleType>{}(ptd, ip);
were replaced withptd[i]
which is more concise and works with PureSoA particles.The PureSoA specialization of numParticlesOutOfRange was removed because the other version also works with PureSoA particles.
Additional background
Checklist
The proposed changes: