EB: Fix corner case #4687
Merged
EB: Fix corner case #4687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the EB cuts off a tiny corner, we may encounter situations where five faces have an aperture of one and the remaining face with an aperture of almost one. In such cases, roundoff errors can significantly affect the computation of the normal and the boundary centroid. This PR addresses the issue by treating faces that are only minimally cut as regular faces.
atmyers
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the EB cuts off a tiny corner, we may encounter situations where five faces have an aperture of one and the remaining face with an aperture of almost one. In such cases, roundoff errors can significantly affect the computation of the normal and the boundary centroid. This PR addresses the issue by treating faces that are only minimally cut as regular faces.