included reset functions for ghost and virtual particle containers#1028
Closed
SreejithNREL wants to merge 1 commit intoAMReX-Combustion:developmentfrom
Closed
included reset functions for ghost and virtual particle containers#1028SreejithNREL wants to merge 1 commit intoAMReX-Combustion:developmentfrom
SreejithNREL wants to merge 1 commit intoAMReX-Combustion:developmentfrom
Conversation
Contributor
|
Oops, I didn't realize this PR was already here. Copilot found this same thing for me and I merged that. Sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: I get the following warning after PeleLMeX run is complete (signalled by AMReX finalize call)
pure virtual method calledterminate called without an active exceptionDependency: Should be used with PelePhysics PR#650, PeleLMeX PR#621
Issue: For some reason, on HIP, the spray particle containers are called by process exit handlers after AMreX finalize call, which results in double freeing and hence the error message
Solution: Enforcing all spray particle containers are destroyed before the AMReX finalize call