Skip to content

Lift dx != dy !=dz restriction for non-EB simulations #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 7, 2025
Merged

Lift dx != dy !=dz restriction for non-EB simulations #964

merged 10 commits into from
Jul 7, 2025

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Jul 2, 2025 •
edited
Loading

Co-authored-by: JhonCordova 74158186+JhonCordova@users.noreply.github.com

@marchdf
Copy link
Contributor Author

marchdf commented Jul 2, 2025 •
edited
Loading

I updated the masscons script to have asserts, better plots and testing on varying number of ncells. This is the resulting plots:

plots.pdf

@marchdf
Copy link
Contributor Author

marchdf commented Jul 3, 2025

Results of the isothermal check:

isothermal-plots.pdf

@marchdf marchdf mentioned this pull request Jul 3, 2025
Merged
@marchdf
Copy link
Contributor Author

marchdf commented Jul 3, 2025 •
edited
Loading

Here's the comparison of the PMF case with dx = 10 dy = 10 dz and dx = 0.1 dy = 0.1dy:

plots.pdf

Zoomed in plots.pdf

@marchdf marchdf requested a review from baperry2 July 3, 2025 20:41
@marchdf marchdf marked this pull request as ready for review July 3, 2025 20:42
@marchdf marchdf enabled auto-merge (squash) July 3, 2025 20:42
@baperry2 baperry2 disabled auto-merge July 7, 2025 03:44
@baperry2 baperry2 merged commit a098469 into development Jul 7, 2025
14 of 16 checks passed
@baperry2 baperry2 deleted the add-d-tests branch July 7, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baperry2 baperry2 baperry2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marchdf @baperry2