-
Notifications
You must be signed in to change notification settings - Fork 56
Single droplet evaporation validation #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single droplet evaporation validation #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about calling this case SingleDropEvap
to be more clear?
To ensure this doesn't break, it should run in the CI. Probably the best way to do this is to add the base case to the CMake tests in ci.yml
. That would leave the python part untested but ensure the Pele part keeps working. To run the python stuff you'd have to choose one of the faster cases and run that in linux.yml
.
I get a deltaT iters not converged
error for the WongLin case. Didn't run everything to completion but others seem to be working.
|
@baperry2, the CI test for SingleDropEvap is failing due to an unused variable, It does not appear that |
Yeah it's better to just get rid of the unused variables if they are truly unused. |
Everything seems to be working now. The last step is to merge PelePhysics #581 and update the corresponding submodule in this LMeX PR. |
This PR migrates and updates the original PeleMP validation tests for single droplet evaporation. It includes:
I will be working on adding new features in PelePhysics for calculating liquid fuel properties, which should help the results from the Nomura et al. case.