SingleDropEvap test for GCM implementation #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baperry2
reviewed
Sep 3, 2025
baperry2
reviewed
Sep 19, 2025
CMake/BuildPelePhysicsLib.cmake
Outdated
| endif() | ||
| target_compile_definitions(${pele_physics_lib_name} PUBLIC PELE_USE_SPRAY PELELM_USE_SPRAY) | ||
| target_compile_definitions(${pele_physics_lib_name} PUBLIC SPRAY_FUEL_NUM=${PELE_PHYSICS_SPRAY_FUEL_NUM}) | ||
| target_compile_definitions(${pele_physics_lib_name} PUBLIC PELE_SPRAY_GCM SPRAY_GCM) |
There was a problem hiding this comment.
Should this be PELE_PHYSICS_SPRAY_GCM instead of SPRAY_GCM to match all the CMakeLists.txt?
There was a problem hiding this comment.
Good catch for consistency.
|
I think this should be good to go now. |
baperry2
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the scripts used to run the GCM vs. PeleMP SingleDropEvap tests shown in PelePhysics #615
SPRAY_GCM=TRUEorFALSE(for PeleMP implementation)Validate.pyscript withLiqPropsType="gcm"or"mp"LiqPropsTypeyou can compare them usingCompareLiqPropsType.pyThis is still a work in progress and needs to be cleaned up a bit before review.