speciesNames for Manifold EOS #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine with this moving the definitions to the header. The only thing is making sure the linkers don't hit "multiple definition" type of errors. |
|
The multiple definition error is resolved by marking the template specializations as |
baperry2
force-pushed
the
specnames
branch
2 times, most recently
from
0ea1c12 to
fe205d8
Compare
…er; improve speciesNames function for manifold
marchdf
approved these changes
Dec 4, 2024
terencelehmann
pushed a commit
to ITV-RWTH/PelePhysics
that referenced
this pull request
Dec 10, 2024
* simplify templated functions in EOS.cpp * rearrange template specializations in EOS.cpp so they are all in header; improve speciesNames function for manifold * SYCL ifdef for manifold speciesnames * pass host eosparm to reactors * ignitionDelay: remove one invalid call for manifold eos * fix dumb bug * clang-tidy unused arguments
baperry2
added a commit
that referenced
this pull request
Dec 23, 2024
* ceptr: Added functionality for reading and converting PLOG reactions. * Do formatting with black * Run isort and flake8 * Latest upstream pull (#2) * pin intel-oneapi version in CI (#541) * Bump Submodules/amrex from `8349789` to `00e6f75` (#540) Bumps [Submodules/amrex](https://github.com/AMReX-Codes/amrex) from `8349789` to `00e6f75`. - [Release notes](https://github.com/AMReX-Codes/amrex/releases) - [Commits](AMReX-Codes/amrex@8349789...00e6f75) --- updated-dependencies: - dependency-name: Submodules/amrex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bruce Perry <Bruce.Perry@nrel.gov> * Make EOS functions templates to allow for CellData as an argument (#536) * template for celldata in EOS * static asserts in templates * templating for RY2 functions for all EOS * Fix clang-tidy (#535) * fix unused variable * free shared ptr for manfunc parm --------- Co-authored-by: Marc T. Henry de Frahan <marc.henrydefrahan@nrel.gov> * Unit conversions (#539) * Utilities and unit conversions * Formatting * 2 structs and renamed functions to avoid macros issue * Templating and namespaces * Added Utilities to Docs * Overload instead of templating * Fixed nested namespaces for clang-tidy error in PeleLMeX, removed Utilities.H from PelePhysics.H.wq (#545) * Update CI to ubuntu-24.04 (#546) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bruce Perry <Bruce.Perry@nrel.gov> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc T. Henry de Frahan <marc.henrydefrahan@nrel.gov> Co-authored-by: Dave Montgomery <David.Montgomery@nrel.gov> Co-authored-by: Jon Rood <jon.rood@nrel.gov> * Adding example mechanism for PLOG evaluation * Bump Submodules/amrex from `00e6f75` to `f27eb69` (#550) Bumps [Submodules/amrex](https://github.com/AMReX-Codes/amrex) from `00e6f75` to `f27eb69`. - [Release notes](https://github.com/AMReX-Codes/amrex/releases) - [Commits](AMReX-Codes/amrex@00e6f75...f27eb69) --- updated-dependencies: - dependency-name: Submodules/amrex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * speciesNames for Manifold EOS (#542) * simplify templated functions in EOS.cpp * rearrange template specializations in EOS.cpp so they are all in header; improve speciesNames function for manifold * SYCL ifdef for manifold speciesnames * pass host eosparm to reactors * ignitionDelay: remove one invalid call for manifold eos * fix dumb bug * clang-tidy unused arguments * ceptr: create pressure-specific folders for plog mechanism, move plog_pressure var into mechanism object * ceptr: implement command line and list options to specify plog pressure * ceptr: Add plog mech to list_mech * ceptr: Copy Make.package to the plog subfolder * add docs on plog mechanism conversion * fix typo fix another typo --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Thomas Howarth <69794367+ThomasHowarth@users.noreply.github.com> Co-authored-by: Bruce Perry <Bruce.Perry@nrel.gov> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc T. Henry de Frahan <marc.henrydefrahan@nrel.gov> Co-authored-by: Dave Montgomery <David.Montgomery@nrel.gov> Co-authored-by: Jon Rood <jon.rood@nrel.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These get read from the table metadata rather than specified at compile time. Therefore, to define them, eosparm needs to be passed to the appropriate function. The implementation should be backward compatible and only require the modified call signature when using Manifold EOS.
This PR also modifies the out-of-class EOS function templates work to eliminate
EOS.cppand reduce redundant code, but perhaps is less readable? Open to suggestion on this.