enable dumping the 1st plane of ghost cells with DiagFramePlane #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malihass
requested changes
May 13, 2025
There was a problem hiding this comment.
Thanks for that, it works great in a turbulent channel flow case!
One change that would be good
Can we dump the error message or the info message only once (not MPI process times)?
Also (not for this PR), but it the LMeX doc, it would be nice to have the dump_ghost_if_OOB option.
|
Modified so the warning only gets printed once. Leaving the error as is, because we want to ensure an error is always raised if needed. Moved Docs here so we don't have to maintain separate Docs for this capability in LMeX and C, and added something for the new flag. |
malihass
approved these changes
May 15, 2025
|
The change to dump the plane at step 0 will need to go in PeleC/LMeX I think |
This was referenced May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the requested plane location for the DiagFramePlane Diagnostic is not available, we just silently do nothing. After this PR, we will raise an error, unless the user has specified the
dump_ghost_if_OOBoption, in which case the first ghost cell in the relevant face will be dumped (all levels get their respective first ghost cell). This is intended as debugging capability, for example giving users direct access to visualize what bcnormal is doing.In PeleLMeX, the first ghost cell on domain boundaries corresponds to the BC at the boundary face.
In PeleC, the first ghost cell on domain boundaries corresponds to the state 1/2 cell over from boundary face, which gets set such that applying standard operators will lead to the desired values on the face.