Skip to content

Conversation

efhunt
Copy link
Contributor

@efhunt efhunt commented Jul 22, 2025

A couple of bug fixes which were missed in testing:

  • Improper use of std::lround the static_case was found resulting in the wrong number of modes being calculated.
  • kz was used where ky should have been resulting in a modified forcing value in non cubic domains.
  • The necessary symmetry breaking modification to Lz in high aspect ratio domains was not implemented in the addTurbVelForces only in the setup.

I apologise for any inconvenience caused.

@baperry2 baperry2 merged commit 8fb2756 into AMReX-Combustion:development Jul 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants