Skip to content

Conversation

d-montgomery
Copy link
Contributor

@d-montgomery d-montgomery commented Sep 1, 2025

This PR builds on the reorganization work done in #581, #602, and #613, and introduces a new group-contribution method (GCM) for estimating liquid-phase properties in the spray module. This method has been shown to be effective at estimating thermodynamic properties of multi-component jet fuels with limited information about the specific compounds in the fuel. Using the GCM in Pele requires:

  • setting SPRAY_GCM=TRUE in the GNUmakefile of the associated PeleLMeX case directory
  • generating an additional liquid-fuel-specific input file from FuelLib following this tutorial provided in that repo's documentation

To minimize headaches from unit conversions, the GCM method is currently only compatible with PeleLMeX, but it can be adapted for cgs units in the future. I've tested the implementation in PeleLMeX/Exec/RegTests/SingleDropEvap and plan to conduct additional tests with POSF10264 in the future. Here is a corresponding LMeX PR where all test cases can be run PeleLMeX #561

Below are the initial results. I think where this method will shine is dealing with complex multi-component fuels like POSF10264, where current mechanisms only have one liquid-phase species and are unable to capture preferential evaporation.
daif_res_2025

wonglin_res_2025 Note: The initial increase in droplet diameter is due to the decrease in liquid density with increasing temperature. Eventually, the droplet starts losing mass and hence leads to a decrease in droplet diameter. runge_simple_res_2025

@baperry2 baperry2 requested a review from Copilot September 3, 2025 20:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a Group Contribution Method (GCM) for estimating liquid-phase properties in the spray module, building on previous reorganization work and providing an alternative to the original PeleMP approach. The GCM uses correlations based on molecular structure information to predict thermodynamic properties of multi-component jet fuels.

Key changes:

  • Adds GCM implementation with temperature-dependent correlations for liquid properties
  • Restructures liquid property classes with inheritance hierarchy
  • Consolidates unit conversion utilities and spray units definition
  • Updates documentation to cover both PeleMP and GCM approaches

Reviewed Changes

Copilot reviewed 8 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
UnitConversions.H Adds temperature conversion functions (Celsius to Kelvin)
SpraySetup.cpp Reorganizes liquid property initialization and adds molecular weight handling
SprayProperties.H Major refactor adding GCM implementation, base class hierarchy, and consolidated unit definitions
SprayFuelData.H Removes duplicate unit definitions (moved to SprayProperties.H)
Drag.H Updates to use liquid molecular weights and simplified vapor state calculations
WallFilm.H Simplifies molecular weight calculation using new mixture functions
Spray.rst Comprehensive documentation update covering both property estimation methods
CONTRIBUTING.md Minor formatting improvements with code block syntax
Comments suppressed due to low confidence (1)

Source/Spray/SprayProperties.H:1

  • The input parameter name 'SP_accentric_factor' in the documentation (line 426) has a spelling error. It should be 'acentric' not 'accentric'.
#ifndef SPRAYPROPERTIES_H

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@baperry2 baperry2 enabled auto-merge (squash) September 8, 2025 18:53
@baperry2 baperry2 merged commit 76d2f9d into AMReX-Combustion:development Sep 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants