-
Notifications
You must be signed in to change notification settings - Fork 59
Initial implementation of spray capability for Manifold EOS #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SreejithNREL
wants to merge
51
commits into
AMReX-Combustion:development
Choose a base branch
from
SreejithNREL:Incl_Mol_Weight
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
62fb5fc
1. Added a new index for reading molecular mass from table. 2. Update…
SreejithNREL 56e0cd8
Removed fixing Wbar to -1
SreejithNREL 330b2a6
Added functionalities to 1. read a generic qty from manifold table gi…
SreejithNREL 81115b8
merging
SreejithNREL 2b1259d
fixed a bug so that GenericReadManifoldData is called only when manif…
SreejithNREL 0faf78d
clang tidyied
SreejithNREL 8126415
changed 'varn' to more meaningful variables names
SreejithNREL a22d34d
Changed function name to Y2GenericManifodlData based on PR review
SreejithNREL ea2002b
used get_values instead of get_value in Y2GenericManifodlData
SreejithNREL 04f4ba3
removed unnecessary string definition
SreejithNREL 08e76fa
merging with dev
SreejithNREL 86e6e07
Error compiling..
SreejithNREL 4899bea
still errors
SreejithNREL b21b986
Added functionality to read species molecular weights from a metadata…
SreejithNREL 55bf45f
works only with metadata file generated from cmlm. Refer PR#12 in cml…
SreejithNREL bf49d1b
add some checks, reorganize code a bit in spray manifold stuff
baperry2 c2a8d69
fix clang-tidy errors
baperry2 fa12941
Merge branch 'development' into Incl_Mol_Weight
baperry2 552cd8e
remove unneeded function declaration in SprayInterpolation
baperry2 9b9d63e
Do body force stuff no matter what EOS for SpraySetup
baperry2 a783f11
Manifold EOS species index/lookup funcs
baperry2 d76ed01
update approach for relationship between gas phase and liquid species
baperry2 65fd559
further refinements for spray setup for manifold
baperry2 bc9769c
further incremental changes
baperry2 2765188
fix some clang-tidy warnings
baperry2 b970142
removing error from get_func not defined as const
SreejithNREL 93d2943
added a templated struct with functor for calcVaporState
SreejithNREL 942d4e4
Completed Step 6 of spray documentation. Code compiles without errors…
SreejithNREL ccc0091
Completed step 6
SreejithNREL 8672353
added function to read in mixture cp and calculate thermal conductivity
SreejithNREL 6e64f36
Removed Wij
SreejithNREL 7c8b27d
A running version on singledropeval case. Make sure to set massfrac[N…
SreejithNREL 453bc2d
changed mw_mix to be calculated from manifold function
SreejithNREL 41e653c
Merge branch 'development' into Incl_Mol_Weight
baperry2 62c0301
spelling error fix
baperry2 873d242
dont const Y2WBAR function
baperry2 3631b20
addressing changes from PR
SreejithNREL 21e1b5a
delete commented code
baperry2 f0fea78
fix some clang-tidy issues
baperry2 407e3b4
Merge branch 'development' into Incl_Mol_Weight
baperry2 5ed2f5a
partial changes toward heat equation for manifold EOS
baperry2 db0ee28
cleanup of manifold calcVaporState
baperry2 b58c80d
temporary hack for fuel Cp for manifold EOS
baperry2 597f3ce
cp in table for spray manifold eos
baperry2 743a881
more refinement of cp indexing or lookups in spray manifold
baperry2 2cec508
return manifold RTY2Cp dummy function
baperry2 2a2175d
merging bruce's commit on heat eqn
SreejithNREL dc1260e
formatting ..
SreejithNREL fbbc7ea
reverting some statements to earlier commit
SreejithNREL 41193a3
initiaize mi_dot variable to 0 in spray
baperry2 aac8e0c
bring back in EOS ifdef for cp_fuel calc
baperry2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.