Skip to content
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
62fb5fc
1. Added a new index for reading molecular mass from table. 2. Update…
SreejithNREL Sep 5, 2025
56e0cd8
Removed fixing Wbar to -1
SreejithNREL Sep 5, 2025
330b2a6
Added functionalities to 1. read a generic qty from manifold table gi…
SreejithNREL Sep 6, 2025
81115b8
merging
SreejithNREL Sep 6, 2025
2b1259d
fixed a bug so that GenericReadManifoldData is called only when manif…
SreejithNREL Sep 8, 2025
0faf78d
clang tidyied
SreejithNREL Sep 8, 2025
8126415
changed 'varn' to more meaningful variables names
SreejithNREL Sep 8, 2025
a22d34d
Changed function name to Y2GenericManifodlData based on PR review
SreejithNREL Sep 9, 2025
ea2002b
used get_values instead of get_value in Y2GenericManifodlData
SreejithNREL Sep 9, 2025
04f4ba3
removed unnecessary string definition
SreejithNREL Sep 9, 2025
08e76fa
merging with dev
SreejithNREL Sep 9, 2025
86e6e07
Error compiling..
SreejithNREL Sep 10, 2025
4899bea
still errors
SreejithNREL Sep 10, 2025
b21b986
Added functionality to read species molecular weights from a metadata…
SreejithNREL Sep 11, 2025
55bf45f
works only with metadata file generated from cmlm. Refer PR#12 in cml…
SreejithNREL Sep 11, 2025
bf49d1b
add some checks, reorganize code a bit in spray manifold stuff
baperry2 Sep 11, 2025
c2a8d69
fix clang-tidy errors
baperry2 Sep 15, 2025
fa12941
Merge branch 'development' into Incl_Mol_Weight
baperry2 Sep 15, 2025
552cd8e
remove unneeded function declaration in SprayInterpolation
baperry2 Sep 17, 2025
9b9d63e
Do body force stuff no matter what EOS for SpraySetup
baperry2 Sep 17, 2025
a783f11
Manifold EOS species index/lookup funcs
baperry2 Sep 17, 2025
d76ed01
update approach for relationship between gas phase and liquid species
baperry2 Sep 17, 2025
65fd559
further refinements for spray setup for manifold
baperry2 Sep 17, 2025
bc9769c
further incremental changes
baperry2 Sep 17, 2025
2765188
fix some clang-tidy warnings
baperry2 Sep 19, 2025
b970142
removing error from get_func not defined as const
SreejithNREL Sep 23, 2025
93d2943
added a templated struct with functor for calcVaporState
SreejithNREL Sep 23, 2025
942d4e4
Completed Step 6 of spray documentation. Code compiles without errors…
SreejithNREL Sep 24, 2025
ccc0091
Completed step 6
SreejithNREL Sep 24, 2025
8672353
added function to read in mixture cp and calculate thermal conductivity
SreejithNREL Sep 24, 2025
6e64f36
Removed Wij
SreejithNREL Sep 24, 2025
7c8b27d
A running version on singledropeval case. Make sure to set massfrac[N…
SreejithNREL Sep 24, 2025
453bc2d
changed mw_mix to be calculated from manifold function
SreejithNREL Sep 24, 2025
41e653c
Merge branch 'development' into Incl_Mol_Weight
baperry2 Sep 25, 2025
62c0301
spelling error fix
baperry2 Sep 25, 2025
873d242
dont const Y2WBAR function
baperry2 Sep 25, 2025
3631b20
addressing changes from PR
SreejithNREL Sep 25, 2025
21e1b5a
delete commented code
baperry2 Sep 25, 2025
f0fea78
fix some clang-tidy issues
baperry2 Sep 25, 2025
407e3b4
Merge branch 'development' into Incl_Mol_Weight
baperry2 Sep 26, 2025
5ed2f5a
partial changes toward heat equation for manifold EOS
baperry2 Sep 26, 2025
db0ee28
cleanup of manifold calcVaporState
baperry2 Sep 26, 2025
b58c80d
temporary hack for fuel Cp for manifold EOS
baperry2 Sep 26, 2025
597f3ce
cp in table for spray manifold eos
baperry2 Sep 26, 2025
743a881
more refinement of cp indexing or lookups in spray manifold
baperry2 Sep 26, 2025
2cec508
return manifold RTY2Cp dummy function
baperry2 Sep 26, 2025
2a2175d
merging bruce's commit on heat eqn
SreejithNREL Sep 26, 2025
dc1260e
formatting ..
SreejithNREL Sep 26, 2025
fbbc7ea
reverting some statements to earlier commit
SreejithNREL Sep 26, 2025
41193a3
initiaize mi_dot variable to 0 in spray
baperry2 Sep 29, 2025
aac8e0c
bring back in EOS ifdef for cp_fuel calc
baperry2 Sep 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Eos/Manifold.H
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ struct Manifold
AMREX_FORCE_INLINE
static void T2Cpi(const amrex::Real /*T*/, amrex::Real* /*Cpi[NUM_SPECIES]*/)
{
// amrex::Abort("\nT2Cpi is not yet implemented for Maniold model");
amrex::Abort("\nT2Cpi is not yet implemented for Maniold model");
}

AMREX_GPU_HOST_DEVICE
Expand Down
7 changes: 0 additions & 7 deletions Source/Spray/Drag.H
Original file line number Diff line number Diff line change
Expand Up @@ -439,22 +439,15 @@ calculateSpraySource(
amrex::Real X_norm = X_vapor[spf] / sumXVap;
Ddiag[fspec] *= X_norm;
rhoDtotal += Ddiag[fspec];
cp_fuel += Y_skin[fspec]; // * cp_n[fspec];

sumYSkin += Y_skin[fspec];
}

#ifndef USE_MANIFOLD_EOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ifdefs are necessary. Y_fuel_skin can't be computed in this way for manifold EOS

amrex::GpuArray<amrex::Real, NUM_SPECIES> Y_fuel_skin;
Y_fuel_skin.fill(0.0);
for (int spf = 0; spf < SPRAY_FUEL_NUM; ++spf) {
Y_fuel_skin[fdat.indx[spf]] = Y_skin[fdat.indx[spf]] / sumYSkin;
}
eos.TY2Cp(T_skin, Y_fuel_skin.data(), cp_fuel);
#else
// Manifold EOS: for now, just taking mixture Cp rather than Fuel Cp
eos.TY2Cp(T_skin, Y_skin.data(), cp_fuel);
#endif
cp_fuel *= SprayUnits::eng_conv;

amrex::Real Sc_skin = mu_skin / rhoDtotal;
Expand Down
Loading