Skip to content

Conversation

d-montgomery
Copy link
Contributor

This PR introduces a general 93 species nonreacting mechanism that can be used with a variety of POSF jet fuels defined in FuelLib.

Included are several input files for the various fuels, which include initial mass fractions from GCxGC data and property predictions for use with the GCM and the original PeleMP spray modules. All transport and thermo properties are from http://rmg.mit.edu

@d-montgomery d-montgomery requested a review from baperry2 October 7, 2025 14:22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to README.md for liquid_fuels_nonreacting explaining where these come from.

Move all these .inp into a subdirectory within liquid_fuels_nonreacting to keep things clean. Usually the .inp file in the Mechanisms directories is the Chemkin format .inp file so separating these will avoid potential confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love having all the repeated species property data for each POSF when really only the Y_0 is changing, but IDK what a better strategy would be here.

Copy link
Contributor Author

@d-montgomery d-montgomery Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear ya. Maybe we provide input files for one fuel for both MP and GCM and leave it up to the user to generate the other input files? We only have a validation case setup for posf10264 so it would make sense to provide those input files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's just do POSF10264 then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I removed all the other POSF fuels in the fuellib_posf_nonreacting mechanism, but left the others in the liquid_fuels_nonreacting mechanism as they are mixture properties and vary from file to file.

@baperry2 baperry2 enabled auto-merge (squash) October 7, 2025 20:33
@baperry2 baperry2 merged commit 3088582 into AMReX-Combustion:development Oct 7, 2025
13 checks passed
@d-montgomery d-montgomery deleted the posf-mech branch October 8, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants