-
Notifications
You must be signed in to change notification settings - Fork 60
Add a big nonreacting mechanism for POSF fuels #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to README.md for liquid_fuels_nonreacting explaining where these come from.
Move all these .inp
into a subdirectory within liquid_fuels_nonreacting to keep things clean. Usually the .inp
file in the Mechanisms directories is the Chemkin format .inp
file so separating these will avoid potential confusion.
Mechanisms/fuellib_posf_nonreacting/spray_input_files/sprayPropsGCM_posf10264.inp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love having all the repeated species property data for each POSF when really only the Y_0 is changing, but IDK what a better strategy would be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hear ya. Maybe we provide input files for one fuel for both MP and GCM and leave it up to the user to generate the other input files? We only have a validation case setup for posf10264 so it would make sense to provide those input files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's just do POSF10264 then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I removed all the other POSF fuels in the fuellib_posf_nonreacting
mechanism, but left the others in the liquid_fuels_nonreacting
mechanism as they are mixture properties and vary from file to file.
This PR introduces a general 93 species nonreacting mechanism that can be used with a variety of POSF jet fuels defined in FuelLib.
Included are several input files for the various fuels, which include initial mass fractions from GCxGC data and property predictions for use with the GCM and the original PeleMP spray modules. All transport and thermo properties are from http://rmg.mit.edu