Skip to content

Fix: resolve debate details modal overflow and scroll issues#381

Open
spinola103 wants to merge 1 commit into
AOSSIE-Org:mainfrom
spinola103:fix/debate-modal-scroll
Open

Fix: resolve debate details modal overflow and scroll issues#381
spinola103 wants to merge 1 commit into
AOSSIE-Org:mainfrom
spinola103:fix/debate-modal-scroll

Conversation

@spinola103

@spinola103 spinola103 commented Mar 31, 2026

Copy link
Copy Markdown

Addressed Issues:

Fixes #370

Screenshots/Recordings:

Before:

  • Content inside the modal was clipped
  • Nested scrolling caused poor UX
  • "Full Conversation" section was partially hidden

After:

  • Single smooth scroll inside modal
  • All sections fully visible
  • Improved spacing and readability
issue370.mp4

Additional Notes:

This fix resolves a UI/UX issue caused by nested scroll containers inside a fixed-height modal.

Changes made:

  • Enabled scrolling at the modal container level (DialogContent)
  • Removed inner scroll constraints from the "Full Conversation" section
  • Ensured consistent layout and spacing across all sections

This results in a cleaner and more accessible user experience.

AI Usage Disclosure:

  • This PR does not contain AI-generated code at all.
  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions
  • If applicable, I have made corresponding changes or additions to the documentation
  • If applicable, I have made corresponding changes or additions to tests
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contribution Guidelines
  • Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
  • I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

Hey @bhavik-mangla, kindly review this PR for issue #370 . Video testing evidence has been included. Thanks

Summary by CodeRabbit

  • Style
    • Enhanced the Debate Details dialog with improved scrolling capabilities to properly accommodate and display larger conversations without content truncation.
    • Refined the Full Conversation transcript section layout and scrolling behavior to optimize content visibility and provide a smoother user experience.

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5913fd9b-9685-4728-afa1-40d9cc0be9a0

📥 Commits

Reviewing files that changed from the base of the PR and between 09ef1bb and 1e2f449.

📒 Files selected for processing (1)
  • frontend/src/Pages/Profile.tsx

📝 Walkthrough

Walkthrough

Updated the Debate Details dialog modal in the Profile component to improve content overflow handling by adding overflow-y-auto to the dialog container while removing internal scrolling constraints from the transcript section, enabling smoother vertical scrolling behavior.

Changes

Cohort / File(s) Summary
Profile Dialog Scrolling
frontend/src/Pages/Profile.tsx
Added overflow-y-auto to DialogContent container for vertical scrolling support; removed fixed-height scrolling (max-h-64 overflow-y-auto) from transcript wrapper to consolidate scroll behavior at the parent level.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


🐰 A modal that scrolls with grace,
No content left out of place,
Fixed heights removed with care,
Now transcripts flow everywhere!
Debate details, crystal clear,
The UI feels perfectly dear! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately summarizes the main change: fixing debate details modal overflow and scroll issues.
Linked Issues check ✅ Passed The code changes fully address all objectives in issue #370: preventing content cutoff via overflow-y-auto, ensuring smooth single-level scrolling by removing nested scroll constraints, and improving visibility and spacing.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the modal overflow and scroll issues in the Debate Details dialog; no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Debate Details modal content overflow and improper display layout

1 participant