feat(ci):fix build deploy workflow #559

uju09 · 2025-10-07T05:58:54Z

Description

This PR fixes the broken Build and Deploy workflow that was caused by recent Play Store compatibility changes and versioning updates. The workflow now properly handles automatic deployment, signing configuration, and artifact management.

Key Changes:

Modified workflow triggers to only run on push to master branch (removed PR triggers as requested)
Added workflow_dispatch for manual triggering capability
Fixed Flutter APK artifact paths from incorrect locations to correct build/app/outputs/flutter-apk/ directory
Corrected duplicate signing configuration in android/app/build.gradle.kts
Added proper secret decoding for keystore, Firebase configs, and Google Services
Implemented unique release versioning using github.run_number instead of static tags
Added automated testing step before builds in both workflows

Fixes #539

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (does not change functionality, e.g. code style improvements, linting)
Documentation update

How Has This Been Tested?

Local Testing:

Ran flutter test - all tests passing
Reviewed workflow syntax for correctness

Workflow Testing:

Will test on feature branch after PR creation (workflows won't run on PR as designed)
After merge to master, both workflows will automatically trigger and validate:
- Build and Deploy workflow (APK build + GitHub release)
- Store Deploy Android workflow (AAB build + Play Store deployment)

Test Configuration:

Flutter Version: 3.35.2
Java Version: 21.0.6
Android compileSdk: 36
Workflow Runner: ubuntu-latest

Files Changed

.github/workflows/build_and_deploy.yml - Complete workflow rewrite with proper configuration
.github/workflows/store_deploy_android.yml - Updated trigger configuration
android/app/build.gradle.kts - Fixed duplicate signing config issue

Breaking Changes

None. This PR maintains backward compatibility while fixing broken functionality:

Workflows still trigger on push to master (existing behavior)
Manual triggering via workflow_dispatch is preserved
Only removed automatic PR triggers which were causing unwanted workflow runs

Description

This PR fixes the broken Build and Deploy workflows by updating trigger configuration and correcting Android build signing setup. The changes address workflow failures caused by Play Store compatibility requirements and ensure proper artifact management.

Fixes #(issue)

Changes Made

1. `.github/workflows/build_and_deploy.yml`

What changed:

Modified trigger from push + pull_request + workflow_dispatch to push (master only) + workflow_dispatch
Added Java 21 and Android SDK setup steps
Added secret decoding for keystore, Firebase configs, and Google Services
Fixed APK artifact path from build/app/outputs/apk/release/ to build/app/outputs/flutter-apk/
Added flutter test step before builds
Changed release tag from static latest_build to dynamic v1.0.${{ github.run_number }}
Added dart-define parameters for Appwrite configuration

Why:

Prevents unwanted workflow runs on PRs
Ensures proper app signing with release keystore
Fixes artifact upload/download failures
Maintains unique release version history

2. `.github/workflows/store_deploy_android.yml`

What changed:

Modified trigger from push (main/master/deploy-actions) + pull_request + workflow_dispatch to push (master only) + workflow_dispatch

Why:

Aligns with consistent trigger policy across workflows
Prevents duplicate/unwanted Play Store deployments on PRs
Maintains manual deployment capability for emergency releases

3. `android/app/build.gradle.kts`

What changed:

Removed duplicate signingConfig = signingConfigs.getByName("debug") line
Moved signingConfigs block outside of buildTypes for proper Kotlin DSL structure
Kept only signingConfig = signingConfigs.getByName("release") in release build type

Why:

Fixes build signing to use release keystore instead of debug
Corrects Kotlin DSL configuration structure
Ensures APKs/AABs are properly signed for Play Store submission

Type of Change

Bug fix (non-breaking change which fixes an issue)

Testing

Local Verification:

Reviewed workflow YAML syntax
Verified build.gradle.kts Kotlin syntax
Confirmed GitHub Secrets are configured
After merge, will monitor workflow execution on master

Expected Behavior After Merge:

Build and Deploy workflow creates signed APKs and GitHub releases
Store Deploy workflow creates AAB and deploys to Play Store internal track
Both workflows only trigger on push to master or manual dispatch

Files Changed

File	Lines Changed	Purpose
`.github/workflows/build_and_deploy.yml`	Complete rewrite	Fix triggers, signing, artifacts
`.github/workflows/store_deploy_android.yml`	Trigger section	Align trigger policy
`android/app/build.gradle.kts`	Signing config	Remove duplicate, fix structure

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings

Additional Notes

Required for Deployment:
Ensure all GitHub Secrets are configured before merge:

ANDROID_KEYSTORE
ANDROID_KEY_PROPERTIES
ANDROID_RELEASE_SERVICE_ACCOUNT
GOOGLE_SERVICES_ANDROID
FIREBASE_OPTIONS
APPWRITE_BASE_DOMAIN
APPWRITE_PROJECT_ID

Post-Merge Validation:
After merging to master, monitor the Actions tab to ensure both workflows complete successfully.

Maintainer Checklist

closes Fix Build and Deploy workflow #539
bug, ci, workflows
Verify all GitHub Secrets are configured before merge
Monitor first workflow run after merge for successful completion

Signed-off-by: Ujwal Akotkar <24bcs012@iiitdwd.ac.in>

…y Store deployment Signed-off-by: Ujwal Akotkar <24bcs012@iiitdwd.ac.in>

github-actions · 2025-10-07T05:59:03Z

🎉 Welcome @uju09!
Thank you for your pull request! Our team will review it soon. 🔍

Please ensure your PR follows the contribution guidelines. ✅
All automated tests should pass before merging. 🔄
If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

coderabbitai · 2025-10-07T05:59:05Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

uju09 · 2025-10-07T06:03:01Z

@M4dhav I request you to review it.

M4dhav · 2025-10-13T17:45:58Z

.github/workflows/store_deploy_android.yml

Changes are not related to the PR, please revert

M4dhav · 2025-10-13T17:46:12Z

android/app/build.gradle.kts

Changes are not related to the PR, please revert

M4dhav · 2025-10-13T17:51:32Z

.github/workflows/build_and_deploy.yml

+        run: |
+          flutter build apk \
+          --release \
+          --split-per-abi \


Is splitting the builds a good idea? This will form different apks for different architectures but most people do not know their architecture. What do you think we should do?

Splitting would mean smaller apks but arguably UX will be a little worse.

uju09 · 2025-10-13T19:33:53Z

@M4dhav I will resolve it.

uju09 added 2 commits October 6, 2025 18:14

feat: Added automated translation checker workflow

9065b51

Signed-off-by: Ujwal Akotkar <24bcs012@iiitdwd.ac.in>

fix(ci): update workflow triggers and fix build configuration for Pla…

8fa6dba

…y Store deployment Signed-off-by: Ujwal Akotkar <24bcs012@iiitdwd.ac.in>

uju09 changed the title ~~feat(ci)/fix build deploy workflow~~ feat(ci):fix build deploy workflow Oct 7, 2025

uju09 added 2 commits October 7, 2025 12:20

Delete .github/scripts/check-translations.dart

f50af76

Delete .github/workflows/translation-check.yml

3352f75

M4dhav assigned uju09 Oct 13, 2025

M4dhav self-requested a review October 13, 2025 17:43

M4dhav added the bug Something isn't working label Oct 13, 2025

M4dhav linked an issue Oct 13, 2025 that may be closed by this pull request

Fix Build and Deploy workflow #539

Open

M4dhav requested changes Oct 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ci):fix build deploy workflow #559

feat(ci):fix build deploy workflow #559

Uh oh!

uju09 commented Oct 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

coderabbitai bot commented Oct 7, 2025

Review skipped

Uh oh!

uju09 commented Oct 7, 2025

Uh oh!

M4dhav Oct 13, 2025

Uh oh!

M4dhav Oct 13, 2025

Uh oh!

M4dhav Oct 13, 2025

Uh oh!

uju09 commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(ci):fix build deploy workflow #559

Are you sure you want to change the base?

feat(ci):fix build deploy workflow #559

Uh oh!

Conversation

uju09 commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Files Changed

Breaking Changes

Description

Changes Made

1. .github/workflows/build_and_deploy.yml

2. .github/workflows/store_deploy_android.yml

3. android/app/build.gradle.kts

Type of Change

Testing

Files Changed

Checklist

Additional Notes

Maintainer Checklist

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

coderabbitai bot commented Oct 7, 2025

Review skipped

Uh oh!

uju09 commented Oct 7, 2025

Uh oh!

M4dhav Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

M4dhav Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

M4dhav Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

uju09 commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

uju09 commented Oct 7, 2025 •

edited

Loading

1. `.github/workflows/build_and_deploy.yml`

2. `.github/workflows/store_deploy_android.yml`

3. `android/app/build.gradle.kts`