You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SVG icon lacks a title/aria-label or role="img" with descriptive text for screen readers; consider making it accessible or marking it decorative with aria-hidden="true" if appropriate.
exportconstSaveTemplateIcon=({ color =baseColor, ...props})=>(<svgxmlns="http://www.w3.org/2000/svg"width="14"height="16"viewBox="0 0 14 16"fill="none"><pathd="M7 5L7 11"stroke={color}strokeWidth="2"strokeLinecap="round"/><pathd="M4 8H10"stroke={color}strokeWidth="2"strokeLinecap="round"/></svg>
Using a fixed 75vh height for '.bundle-table-body' may cause overflow or layout issues on small screens; verify responsive behavior and whether max-height would be more suitable.
A fixed 75vh height can cause overflow or clipped content on small screens and inside nested scroll containers. Use a max-height with overflow control to prevent layout breakage while keeping intended sizing.
Why: Replacing fixed height with max-height and adding overflow control can improve responsiveness and prevent clipping; it's contextually valid and low risk, though not strictly required.
Medium
Make icon size responsive
The icon uses a fixed pixel size, which can render blurry on high-DPI screens and is inflexible. Expose width and height via ...props and default to 1em so the icon scales with font size while preserving the current viewBox.
Why: Exposing width/height via props improves flexibility and scalability; the change is accurate to the snippet, though it slightly alters component API and isn't critical to the PR's intent.
Low
Restore minimal icon outline
The removed filled path likely provided the icon's bounding shape; without it, the plus may be hard to see on transparent or light backgrounds and hit-area could be too small. Add a non-filled, low-opacity outline or minimal bounding shape to preserve visibility and accessibility without reverting to a fully filled icon.
Why: Valid concern about visibility after removing the filled bounding shape, and the proposed outline is a reasonable compromise; however, it changes the icon design and may not align with intended visual updates.
The props spread isn't applied to the , making it impossible to pass accessibility or sizing attributes. Spread ...props onto the element to restore extensibility.
Why: Correctly identifies that ...props is not spread onto the <svg>, limiting accessibility and flexibility. The fix is accurate and low-risk, improving extensibility.
Medium
Preserve optional icon background
Removing the filled background path may break visual contrast in themes expecting a solid icon. Consider retaining an optional background path controlled by a prop to avoid regressions while allowing outline style.
Why: Valid concern about removing the filled background path; offering an optional prop is reasonable and backward-compatible. Impact is moderate since it's a visual/UX regression risk, and the improved code accurately applies the change.
Low
Prevent table overflow and clipping
Hard-coding 75vh can cause the table body to overflow small viewports and hide content. Constrain height with min/max or use max-height and enable scrolling to prevent clipping.
Why: Suggestion is reasonable to improve usability on small viewports by using max-height and scrolling; however, it changes intended layout and may not be universally desired. Improvement is contextual and moderate in impact.
Removing absolute positioning without defining a layout context can cause the empty state message to shift layout or overlap content depending on parent styles. If the intent is to center within the table area, switch to flex centering to maintain predictable placement without overlap.
Why: Replacing removed absolute positioning with flex centering is a reasonable, low-risk way to keep the empty state predictably centered without overlap, though it assumes the parent layout supports this and may not be strictly necessary.
Low
Preserve icon bounding box
The previous filled path defining the icon's boundary was removed, which may cause the icon to become invisible on backgrounds that match the page color and shrink the tappable area. Add an explicit transparent rectangle to preserve the 14x16 viewbox hit area and ensure consistent rendering across themes.
Why: Adding a transparent rect can help maintain a consistent hit area, but SVG pointer events on transparent fills may not improve accessibility by default and the icon remains visible due to strokes; impact is minor and context-dependent yet harmless.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Issue Tracking
JIRA: https://aottech.atlassian.net/browse/FWF-5349
Issue Type: BUG
Changes
PR Type
Bug fix, Enhancement
Description
Clean up SaveTemplateIcon SVG path
Maintain icon stroke-only design
Minor SCSS table bundle tweak
Diagram Walkthrough
File Walkthrough
index.tsx
Simplify SaveTemplateIcon to stroke-onlyforms-flow-components/src/components/SvgIcons/index.tsx
SaveTemplateIcon.colorfor strokes._table.scss
Minor bundle table body style adjustmentforms-flow-theme/scss/_table.scss
.bundle-table-bodyblock.