Skip to content

Add Multi-Arch Support for Forms-flow-analytics #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: formsflow-merge
Choose a base branch
from
Open

Add Multi-Arch Support for Forms-flow-analytics #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
105ae91
Merge pull request #38 from shuhaib-aot/formsflow
shuhaib-aot Oct 4, 2024
c9f4a64
Merge branch 'AOT-Technologies:formsflow' into FWF-4287-Multi-arch-image
sinto-aot Jan 27, 2025
9b10c36
Add Multi-Arch Support for Forms-flow-analytics
sinto-aot Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/formsflow-analytics-push-to-dockerhub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ jobs:
uses: docker/build-push-action@v2
with:
context: ${{ matrix.context }}
platforms: linux/amd64,linux/arm64/v8
# builder: ${{ steps.buildx.outputs.name }}
push: true
# file: ${{ matrix.dockerfile }}
Expand Down
8 changes: 5 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM node:18-bookworm as frontend-builder
# Use multi-architecture base images
FROM --platform=$BUILDPLATFORM node:18-bookworm as frontend-builder

RUN npm install --global --force yarn@1.22.19

Expand Down Expand Up @@ -27,7 +28,8 @@ COPY --chown=redash webpack.config.js /frontend/
# Use `yarn run` to ensure the locally installed webpack is used
RUN yarn clean && yarn build:viz && NODE_OPTIONS=--openssl-legacy-provider NODE_ENV=production yarn run webpack && mkdir -p /frontend/client/dist && touch /frontend/client/dist/multi_org.html && touch /frontend/client/dist/index.html

FROM python:3.8-slim-bookworm
# Use multi-architecture base images
FROM --platform=$BUILDPLATFORM python:3.8-slim-bookworm

EXPOSE 5000

Expand Down Expand Up @@ -83,4 +85,4 @@ RUN chown redash /app
USER redash

ENTRYPOINT ["/app/bin/docker-entrypoint"]
CMD ["server"]
CMD ["server"]