publish unminfied

[juliusmarminge]

Why are you publishing the package minified? You're not exposing many options to the underlying Shiki instance so I wanted to patch the package to have more control but that's not very easy to do when the code is all minified.

[AVGVSTVS96]

Thanks for pointing this out, and your PR! This is my first library so I didn't know that it's preferable to publish it unminified, I figured that would increase bundle size but I'm realizing that the minification is generally done by the user's bundler, not the package author.

If I may ask, what other features are you looking for in react-shiki? It's still early stage but I'm planning to add a lot more features and functionality and am happy to take suggestions!

Next feature will be allowing users to create fine grained bundles and/or pass their own highlighter instance

[juliusmarminge]

This is my first library so I didn't know that it's preferable to publish it unminified

No worries!

I figured that would increase bundle size but I'm realizing that the minification is generally done by the user's bundler, not the package author.

Yes exactly. If you really want to please those who load the lib from a CDN without additional bundling steps you can include a index.min.js as well, but most apps use a bundler and so the minification process happens there

[juliusmarminge]

If I may ask, what other features are you looking for in react-shiki? It's still early stage but I'm planning to add a lot more features and functionality and am happy to take suggestions!

We needed to give some additional options to the singleton Shiki instance (langAlias for example) and you didn't expose that. Making a patch to a minified package is hard, which is the reason I came here in the first place :)

So to answer your question, more control would be my first feedback. Expose options to the underlying Shiki instance to allow users to customize to their needs 👍🏼

[AVGVSTVS96]

We needed to give some additional options to the singleton Shiki instance (langAlias for example) and you didn't expose that. Making a patch to a minified package is hard, which is the reason I came here in the first place :)

So to answer your question, more control would be my first feedback. Expose options to the underlying Shiki instance to allow users to customize to their needs 👍🏼

Ah yes, we currently only expose codeToHast options, I can add support to pass langAlias through as well. langs and themes passed to getSingletonHighlighter (used in react-shiki and react-shiki/web) are handled internally, I don't think there would be a benefit to exposing them, would there?

When you use react-shiki/core (added in #59) you can create a custom highlighter directly and pass it to the hook or component, does this cover your needs until I implement support for langAlias?

[juliusmarminge]

When you use react-shiki/core (added in #59) you can create a custom highlighter directly and pass it to the hook or component, does this cover your needs until I implement support for langAlias?

That sounds like a good solution. I'll try it when I'm home later tonight

[juliusmarminge]

Just opened #68 to support langAlias