Log MuJoCo errors through BSKLogger #1022
Open
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-g-bonilla
force-pushed
the
feature/1021-mujoco-logging
branch
from
2d48046 to
41040e0
Compare
schaubh
reviewed
Jul 8, 2025
| @@ -46,6 +46,7 @@ Version |release| | |||
| - Fixed a bug in :ref:`spiceInterface` where required kernels were being unloaded before they were no longer needed. | |||
| - Fixed an issue where the :ref:`spaceToGroundTransmitter` would check for the amount of data remaining in a different partition than the one being downlinked. | |||
| - Fixed an issue where a high baud rate prevented the :ref:`spaceToGroundTransmitter` from downlinking data from the :ref:`simpleStorageUnit` or :ref:`partitionedStorageUnit`. | |||
| - Redirected MuJoCo errors and warnings to ``BSKLogger`` instead of printing to file. | |||
There was a problem hiding this comment.
make BSKLogger a hyperlink using
:ref:`bskLogging`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original issue:
To address this, we set the custom error/warning callbacks in MuJoCo to call
BSKLogger::bskLog. For the case of the error callback, we also throw an exception (as the program is expected to be interrupted).Verification
Manually triggered erroneous behavior and asserted that no log file is created, but rather the logger is used. Feature is considered non-critical and small enough to not require a regtest.
Documentation
Release notes updated.