Skip to content

Commit 0bb51dc

Browse files
authored
Audit Fixes 11: Dead code in the migration function (#555)
1 parent 3ec6c45 commit 0bb51dc

File tree

1 file changed

+2
-30
lines changed

1 file changed

+2
-30
lines changed

framework/contracts/account/src/migrate.rs

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -45,23 +45,15 @@ pub fn migrate_from_xion_account(
4545
env: Env,
4646
current_contract_version: cw2::ContractVersion,
4747
) -> AccountResult {
48-
use crate::{
49-
modules::{_install_modules, MIGRATE_CONTEXT},
50-
msg::ExecuteMsg,
51-
};
48+
use crate::modules::{_install_modules, MIGRATE_CONTEXT};
5249
use ::{
5350
abstract_sdk::feature_objects::RegistryContract,
5451
abstract_sdk::std::account::state::ACCOUNT_ID,
5552
abstract_std::account::ModuleInstallConfig,
5653
abstract_std::objects::module::ModuleInfo,
5754
abstract_std::objects::AccountId,
5855
abstract_std::{
59-
account::{
60-
state::{
61-
AccountInfo, WhitelistedModules, INFO, SUSPENSION_STATUS, WHITELISTED_MODULES,
62-
},
63-
UpdateSubAccountAction,
64-
},
56+
account::state::{WhitelistedModules, SUSPENSION_STATUS, WHITELISTED_MODULES},
6557
objects::{
6658
gov_type::GovernanceDetails,
6759
ownership::{self},
@@ -96,15 +88,6 @@ pub fn migrate_from_xion_account(
9688
ACCOUNT_ID.save(deps.storage, &account_id)?;
9789
WHITELISTED_MODULES.save(deps.storage, &WhitelistedModules(vec![]))?;
9890

99-
let account_info = AccountInfo {
100-
name: None,
101-
description: None,
102-
link: None,
103-
};
104-
105-
if account_info.has_info() {
106-
INFO.save(deps.storage, &account_info)?;
107-
}
10891
MIGRATE_CONTEXT.save(deps.storage, &vec![])?;
10992

11093
let governance = GovernanceDetails::AbstractAccount {
@@ -127,17 +110,6 @@ pub fn migrate_from_xion_account(
127110
vec![],
128111
)?);
129112

130-
// Register on account if it's sub-account
131-
if let GovernanceDetails::SubAccount { account } = cw_gov_owner.owner {
132-
response = response.add_message(wasm_execute(
133-
account,
134-
&ExecuteMsg::UpdateSubAccount(UpdateSubAccountAction::RegisterSubAccount {
135-
id: ACCOUNT_ID.load(deps.storage)?.seq(),
136-
}),
137-
vec![],
138-
)?);
139-
}
140-
141113
let install_modules = vec![ModuleInstallConfig::new(
142114
ModuleInfo::from_id_latest(IBC_CLIENT)?,
143115
None,

0 commit comments

Comments
 (0)