Audit Fixes 9 : Misleading success response for non-xion auth operations (#553)

Author: Kayanski

framework/contracts/account/src/error.rs

@@ -121,6 +121,9 @@ pub enum AccountError {
         contract: String,
     },
 
+    #[error("No auth methods capabilities on this account (xion feature disabled)")]
+    NoAuthMethods {},
+
     #[error("Abstract Account don't have Authentication")]
     AbsAccNoAuth {},
 

framework/contracts/account/src/execution.rs

@@ -131,7 +131,7 @@ pub fn add_auth_method(
     }
     #[cfg(not(feature = "xion"))]
     {
-        Ok(AccountResponse::action("add_auth"))
+        Err(AccountError::NoAuthMethods {})
     }
 }
 
@@ -143,7 +143,7 @@ pub fn remove_auth_method(_deps: DepsMut, _env: Env, _info: MessageInfo, _id: u8
     }
     #[cfg(not(feature = "xion"))]
     {
-        Ok(AccountResponse::action("remove_auth"))
+        Err(AccountError::NoAuthMethods {})
     }
 }