Skip to content

ABS-384 : Rename adapter and app apis request fn to execute #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Apr 23, 2024

This PR aims at renaming request endpoints to execute, because request doesn't mean anything in cosmwasm-std

Checklist

  • CI is green.
  • Changelog updated.

@github-actions github-actions bot added the sdk label Apr 23, 2024
Copy link

cloudflare-workers-and-pages bot commented Apr 23, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86f8f24
Status: ✅  Deploy successful!
Preview URL: https://ffbfbe29.abstract-docs.pages.dev
Branch Preview URL: https://nicolas-abs-384-rename-adapt.abstract-docs.pages.dev

View logs

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.9%. Comparing base (21e55ad) to head (f834159).
Report is 101 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
...ramework/packages/abstract-sdk/src/apis/adapter.rs 93.7% <100.0%> (ø)
framework/packages/abstract-sdk/src/apis/app.rs 95.6% <100.0%> (ø)

... and 22 files with indirect coverage changes

@CyberHoward CyberHoward added this to the v0.22 milestone Apr 25, 2024
@Kayanski Kayanski requested a review from Buckram123 April 29, 2024 17:18
Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Buckram123
Copy link
Collaborator

@Kayanski would you mind adding it to the changelog? Path to the changelog: framework/docs/src/releases/v0.md

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 30, 2024
@Kayanski Kayanski merged commit 025a52b into main Apr 30, 2024
@Kayanski Kayanski deleted the nicolas/abs-384-rename-adapter-and-app-apis-request-fn-to-execute branch April 30, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants