-
Notifications
You must be signed in to change notification settings - Fork 23
Added api to query wether an address is a module #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added api to query wether an address is a module #329
Conversation
Deploying abstract-docs with
|
Latest commit: |
0aabd36
|
Status: | ✅ Deploy successful! |
Preview URL: | https://731d6ea9.abstract-docs.pages.dev |
Branch Preview URL: | https://nicolas-abs-383-add-module-v.abstract-docs.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'm not sure if Native
and AccountBase
module types should be included as well
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
This PR aims at adding an API to query wether an address is registered Abstract SDK Module.
Major Changes
We added a single query in the ModuleRegistry API
Here are the steps of the query :
TODO
Clippy doesn't pass because AbstractSDkError has large differences between variants. We need to find a solution (not take Module but String instead in the WrongModule variant ?)
Checklist