Skip to content

Enabled IBC calls by default on remote accounts #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Apr 23, 2024

This PR aims at enabling IBC calls by default on remote accounts.
This is a starting point for duplex communication between remote accounts

Closes ABS-382

Major Change

On manager instantiation, if the account id is remote, we install the ibc client on the account.

Checklist

  • CI is green.
  • Changelog updated.

Copy link

cloudflare-workers-and-pages bot commented Apr 23, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e24713
Status: ✅  Deploy successful!
Preview URL: https://d016f1a5.abstract-docs.pages.dev
Branch Preview URL: https://nicolas-abs-381-add-endpoint.abstract-docs.pages.dev

View logs

@CyberHoward CyberHoward added this to the v0.22 milestone Apr 25, 2024
@Kayanski Kayanski requested a review from Buckram123 April 29, 2024 17:19
Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I'm missing something, can't this module install be added to the API instead of inside contract? For example here: https://docs.rs/abstract-client/latest/abstract_client/struct.Account.html#method.create_ibc_account we can check if ibc-client inside install_modules and if it's not just push latest version. But inside contract we just check that this module is installed.

Also changelog

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 86.8%. Comparing base (21e55ad) to head (8e24713).
Report is 107 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
...ramework/contracts/account/manager/src/commands.rs 95.1% <0.0%> (+<0.1%) ⬆️
...packages/abstract-interface/src/account/manager.rs 53.7% <0.0%> (-2.2%) ⬇️
framework/packages/abstract-client/src/account.rs 84.3% <0.0%> (-1.2%) ⬇️

... and 112 files with indirect coverage changes

@Kayanski Kayanski merged commit bcd53df into main Apr 30, 2024
@Kayanski Kayanski deleted the nicolas/abs-381-add-endpoint-to-ibc-host-that-enables-calling-module-on branch April 30, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account documentation Improvements or additions to documentation interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants