-
Notifications
You must be signed in to change notification settings - Fork 23
Enabled IBC calls by default on remote accounts #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled IBC calls by default on remote accounts #330
Conversation
Deploying abstract-docs with
|
Latest commit: |
8e24713
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d016f1a5.abstract-docs.pages.dev |
Branch Preview URL: | https://nicolas-abs-381-add-endpoint.abstract-docs.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I'm missing something, can't this module install be added to the API instead of inside contract? For example here: https://docs.rs/abstract-client/latest/abstract_client/struct.Account.html#method.create_ibc_account
we can check if ibc-client
inside install_modules
and if it's not just push latest version. But inside contract we just check that this module is installed.
Also changelog
…ndpoint-to-ibc-host-that-enables-calling-module-on
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
This PR aims at enabling IBC calls by default on remote accounts.
This is a starting point for duplex communication between remote accounts
Closes ABS-382
Major Change
On
manager
instantiation, if the account id is remote, we install the ibc client on the account.Checklist