Skip to content

Duplex IBC for Accounts #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Apr 23, 2024

This PR aims at allowing duplex communication for abstract IBC accounts (remote can also call the local account).

Current Status

When the IBC host receives an IBC message, it appends the sending chain name to the account trace before proceeding with executing the sent action.

Major changes

When the IBC host receives an IBC message, it modifies the account trace in the following way before proceeding with executing the sent action :

  • If the account_id is remote and the last trace matches the current chain, we pop the chain name
  • Otherwise, we just add the sending chain to the trace

Outstanding problem

The IBC host needs to be a manager of the resulting abstract account to be able to execute messaes on their behalf.
--> The IBC host should be an admin of the manager of all abstract accounts that have IBC enabled.

Checklist

  • CI is green.
  • Changelog updated.

@Kayanski Kayanski marked this pull request as draft April 23, 2024 14:51
Copy link

cloudflare-workers-and-pages bot commented Apr 23, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f9fc63
Status: ✅  Deploy successful!
Preview URL: https://aedffc22.abstract-docs.pages.dev
Branch Preview URL: https://nicolas-abs-381-add-duplex-i.abstract-docs.pages.dev

View logs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 86.9%. Comparing base (fc805d6) to head (6f9fc63).

Additional details and impacted files
Files Coverage Δ
.../contracts/native/ibc-host/src/endpoints/packet.rs 85.5% <50.0%> (-8.8%) ⬇️

... and 1 file with indirect coverage changes

Base automatically changed from nicolas/abs-381-add-endpoint-to-ibc-host-that-enables-calling-module-on to main April 30, 2024 08:08
@CyberHoward CyberHoward closed this Jun 7, 2024
@CyberHoward
Copy link
Contributor

Closing because of outstanding problem. Duplex module <> module IBC should account for all practical usecases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants