Merge pull request #873 from Adamant-im/trello.com/c/aIVBEdjR

[trello.com/c/SL4zLZnb] Small code improvments

Author: Lainaaa

Adamant/Models/BTCRawTransaction.swift

@@ -27,7 +27,7 @@ struct BTCRawTransaction {
 
     func asBtcTransaction<T: BaseBtcTransaction>(_ as: T.Type, for address: String, blockId: String? = nil) -> T {
         // MARK: Known values
-        var confirmationsValue: String? = nil
+        var confirmationsValue: String?
         var transactionStatus: TransactionStatus = .registered
 
         if let confirmations = confirmations {

Adamant/Modules/Wallets/Bitcoin/BtcWalletService+RichMessageProviderWithStatusCheck.swift

@@ -44,8 +44,8 @@ extension BtcWalletService {
         transaction: CoinTransaction,
         btcTransaction: BtcTransaction
     ) async -> TransactionStatus {
-        // Before we already stored another status in RawBtcTransactionResponse.asBtcTransaction(_:for:height:).
-        // So we don't need to double check anything here because it is already at least "registered".
+        // The status was already set in RawBtcTransactionResponse.asBtcTransaction(_:for:height:),
+        // so there's no need to check again for `.registered` — at this point it's guaranteed to be at least that.
         guard let status = btcTransaction.transactionStatus else {
             return .inconsistent(.unknown)
         }