Skip to content

[trello.com/c/aZtAfZ44] fix select row when we enter the chat via popup #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

vovameister
Copy link
Member

No description provided.

Copy link
Collaborator

@Lainaaa Lainaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move updateSelectedRow into the presenter and just on presentChatroom also call updateSelectedRow. We can make it via delegate pattern for example. Because now dev will need to know about your know method and call it when it want to add new functionality for example, lets care about future us and future other devs of this project!

@vovameister vovameister requested a review from Lainaaa May 27, 2025 17:27
Copy link
Collaborator

@Lainaaa Lainaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code look to be good!

However, make sure to name your commit! Lets care about our commit history.
So in this case I suggest to squash the commits.

@vovameister vovameister force-pushed the trello.com/c/aZtAfZ44 branch from 4bb9933 to 416a4ae Compare May 28, 2025 16:20
@vovameister vovameister requested a review from Lainaaa May 28, 2025 16:20
@vovameister vovameister merged commit d89a78d into release/3.11.0 May 28, 2025
2 checks passed
@vovameister vovameister deleted the trello.com/c/aZtAfZ44 branch May 28, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants