Fixed fatal error when coming across a sub-group.

This doesn't fix sub-group handling, it just ignores them and carries on.

#6

Author: Adambean

README.md

@@ -20,6 +20,10 @@ Features implemented:
 * Synchronising groups to Gitlab
 * Synchronising Gitlab group memberships based on LDAP group memberships
 
+Not implemented:
+
+* Sub-group handling
+
 If in doubt use the dry run `-d` option to prevent writing to Gitlab first, combined with `-vv` to see exactly what would happen.
 
 **You have been warned!**

src/LdapSyncCommand.php

@@ -1359,6 +1359,11 @@ private function deployGitlabUsersAndGroups(array $config, string $gitlabInstanc
 
             $membersOfThisGroup = [];
             foreach ($usersToSyncMembership as $gitlabUserId => $gitlabUserName) {
+                if (!isset($ldapGroupsSafe[$gitlabGroupName]) || !is_array($ldapGroupsSafe[$gitlabGroupName])) {
+                    $this->logger->warning(sprintf("Group \"%s\" doesn't appear to exist at path \"%s\". (Is this a sub-group? Sub-groups are not supported yet.)", $gitlabGroupName, $gitlabGroupPath));
+                    continue;
+                }
+
                 if (!$this->in_array_i($gitlabUserName, $ldapGroupsSafe[$gitlabGroupName])) {
                     continue;
                 }